Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3104)

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.h

Issue 1808083002: Migrate ExtensionPopup from BubbleDelegateView to (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/extension_popup.h
diff --git a/chrome/browser/ui/views/extensions/extension_popup.h b/chrome/browser/ui/views/extensions/extension_popup.h
index 4f7845867469672abb8b4d1032fe84194b4a1dc0..1ddbf6f1fe8274aabe3501001ce81f47066056e8 100644
--- a/chrome/browser/ui/views/extensions/extension_popup.h
+++ b/chrome/browser/ui/views/extensions/extension_popup.h
@@ -12,7 +12,7 @@
#include "chrome/browser/ui/views/extensions/extension_view_views.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
-#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/bubble/bubble_dialog_delegate.h"
#include "url/gurl.h"
@@ -30,7 +30,7 @@ class ExtensionViewHost;
}
// The bubble used for hosting a browser-action popup provided by an extension.
-class ExtensionPopup : public views::BubbleDelegateView,
+class ExtensionPopup : public views::BubbleDialogDelegateView,
public ExtensionViewViews::Container,
public content::NotificationObserver,
public TabStripModelObserver {
@@ -56,9 +56,11 @@ class ExtensionPopup : public views::BubbleDelegateView,
views::BubbleBorder::Arrow arrow,
ShowAction show_action);
-
extensions::ExtensionViewHost* host() const { return host_.get(); }
+ // views::BubbleDialogDelegateView overrides.
+ int GetDialogButtons() const override;
+
// content::NotificationObserver overrides.
void Observe(int type,
const content::NotificationSource& source,
« no previous file with comments | « chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc ('k') | chrome/browser/ui/views/extensions/extension_popup.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698