Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1807913002: [crankshaft] Support calling JS runtime functions. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Support calling JS runtime functions. This should recover regression caused by 7f11fba720dd82d3b605f9f58e7180a1fc760421 (https://codereview.chromium.org/1739233002). TBR=bmeurer@chromium.org BUG=chromium:592692, chromium:595265 LOG=N Committed: https://crrev.com/80779dc739124b4498b69a60cd68021cef4faee3 Cr-Commit-Position: refs/heads/master@{#34824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M src/ast/ast-numbering.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/bailout-reason.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +15 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807913002/1
4 years, 9 months ago (2016-03-16 15:11:56 UTC) #3
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-16 15:16:12 UTC) #5
Michael Starzinger
LGTM. +Michael: FYI, you might be interested in this.
4 years, 9 months ago (2016-03-16 15:28:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807913002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807913002/1
4 years, 9 months ago (2016-03-16 15:37:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 15:55:38 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 15:56:42 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80779dc739124b4498b69a60cd68021cef4faee3
Cr-Commit-Position: refs/heads/master@{#34824}

Powered by Google App Engine
This is Rietveld 408576698