Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Issue 1739233002: [runtime] Remove obsolete %Apply and %TailCall runtime entries. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Remove obsolete %Apply and %TailCall runtime entries. The %TailCall runtime entry and the %_TailCall intrinsic is not used, and will never be used (because %TailCall doesn't actually do a tail call). We will soon have proper ES6 tail calls, which are correct and properly tested. The %Apply runtime entry is basically a super-slow, less correct version of Reflect.apply, so we can as well just use Reflect.apply, which is exposed to builtins via %reflect_apply. R=ishell@chromium.org Committed: https://crrev.com/7f11fba720dd82d3b605f9f58e7180a1fc760421 Cr-Commit-Position: refs/heads/master@{#34317}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -189 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/prologue.js View 1 chunk +4 lines, -4 lines 0 comments Download
M src/js/regexp.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/runtime/runtime-function.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M test/mjsunit/strong/function-arity.js View 2 chunks +2 lines, -4 lines 0 comments Download
D test/mjsunit/tail-call-intrinsic.js View 1 chunk +0 lines, -108 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-26 07:34:42 UTC) #1
Benedikt Meurer
Hey Igor, Remove dead intrinsics, so no one accidentially uses them. Please take a look. ...
4 years, 10 months ago (2016-02-26 07:35:52 UTC) #2
Igor Sheludko
lgtm
4 years, 10 months ago (2016-02-26 08:01:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1739233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1739233002/1
4 years, 10 months ago (2016-02-26 08:08:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-26 08:09:46 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 08:10:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7f11fba720dd82d3b605f9f58e7180a1fc760421
Cr-Commit-Position: refs/heads/master@{#34317}

Powered by Google App Engine
This is Rietveld 408576698