Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1811563002: [fullcodegen] Avoid arguments juggling when calling a JS runtime function. (Closed)

Created:
4 years, 9 months ago by Igor Sheludko
Modified:
4 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@call-js-runtime
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Avoid arguments juggling when calling a JS runtime function. Committed: https://crrev.com/65dcd25585cb5cab946f9731b60a066449435b17 Cr-Commit-Position: refs/heads/master@{#34825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -61 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811563002/1
4 years, 9 months ago (2016-03-16 15:15:26 UTC) #2
Igor Sheludko
PTAL
4 years, 9 months ago (2016-03-16 15:16:48 UTC) #4
Michael Starzinger
LGTM. Very nice! I was just thinking about the same cleanup while looking at your ...
4 years, 9 months ago (2016-03-16 15:32:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 15:48:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811563002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811563002/1
4 years, 9 months ago (2016-03-16 16:00:45 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 16:02:44 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 16:03:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/65dcd25585cb5cab946f9731b60a066449435b17
Cr-Commit-Position: refs/heads/master@{#34825}

Powered by Google App Engine
This is Rietveld 408576698