Make test_runner::AppBannerClient an internal detail of components/test_runner.

Make test_runner::AppBannerClient an internal detail of components/test_runner.

WebTestInterfaces::GetAppBannerClient can be removed, because
TestRunner::ResolveBeforeInstallPromptPromise can interact with
AppBannerClient directly, rather than going through WebTestDelegate.
This also means that components/test_runner/app_banner_client.h header
no longer needs to be included outside of components/test_runner.

BUG=595089
Committed: https://crrev.com/27bbd7475ee6baef2c72ab03205abde2fa8b95f7
Cr-Commit-Position: refs/heads/master@{#381797}

[Łukasz Anforowicz, 2016-03-15 21:57:28]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-03-15 21:57:29]

jochen@, can you take a look please?

https://codereview.chromium.org/1807643002/diff/20001/components/test_runner/...
File components/test_runner/app_banner_client.h (right):

https://codereview.chromium.org/1807643002/diff/20001/components/test_runner/...
components/test_runner/app_banner_client.h:32: // otherwise it will be
'dismissed'.
The comment is moved here from web_test_delegate.h from the (deleted)
WebTestDelegate::ResolveBeforeInstallPromptPromise.

https://codereview.chromium.org/1807643002/diff/20001/components/test_runner/...
File components/test_runner/test_runner.cc (right):

https://codereview.chromium.org/1807643002/diff/20001/components/test_runner/...
components/test_runner/test_runner.cc:2938:
test_interfaces_->GetAppBannerClient()->ResolvePromise(request_id, platform);
This is what the delegate (i.e. BlinkTestRunner) would have done - let's do it
right here.

https://codereview.chromium.org/1807643002/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/blink_test_runner.cc (left):

https://codereview.chromium.org/1807643002/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/blink_test_runner.cc:38: #include
"components/test_runner/tracked_dictionary.h"
Not really part of this CL... :-/  But it is also unnecessary to include this
header.

https://codereview.chromium.org/1807643002/diff/20001/content/shell/renderer/...
File content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
(right):

https://codereview.chromium.org/1807643002/diff/20001/content/shell/renderer/...
content/shell/renderer/layout_test/layout_test_content_renderer_client.cc:28:
#include
"third_party/WebKit/public/platform/modules/app_banner/WebAppBannerClient.h"
scoped_ptr (in LayoutTestContentRendererClient::CreateAppBannerClient) needs to
know about the virtual destructor of WebAppBannerClient.

[jochen (gone - plz use gerrit), 2016-03-17 19:49:47]

lgtm

[Łukasz Anforowicz, 2016-03-17 20:36:10]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-03-17 20:36:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807643002/40001

[commit-bot: I haz the power, 2016-03-17 21:13:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-17 21:15:35]

Description was changed from

==========
Make test_runner::AppBannerClient an internal detail of components/test_runner.

WebTestInterfaces::GetAppBannerClient can be removed, because
TestRunner::ResolveBeforeInstallPromptPromise can interact with
AppBannerClient directly, rather than going through WebTestDelegate.
This also means that components/test_runner/app_banner_client.h header
no longer needs to be included outside of components/test_runner.

BUG=595089
==========

to

==========
Make test_runner::AppBannerClient an internal detail of components/test_runner.

WebTestInterfaces::GetAppBannerClient can be removed, because
TestRunner::ResolveBeforeInstallPromptPromise can interact with
AppBannerClient directly, rather than going through WebTestDelegate.
This also means that components/test_runner/app_banner_client.h header
no longer needs to be included outside of components/test_runner.

BUG=595089

Committed: https://crrev.com/27bbd7475ee6baef2c72ab03205abde2fa8b95f7
Cr-Commit-Position: refs/heads/master@{#381797}
==========

[commit-bot: I haz the power, 2016-03-17 21:15:37]

Patchset 3 (id:??) landed as
https://crrev.com/27bbd7475ee6baef2c72ab03205abde2fa8b95f7
Cr-Commit-Position: refs/heads/master@{#381797}