DynamicsCompressor.reduction is a float not an AudioParam

DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9BAQAJ

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html, dynamicscompressor-simple.html, dynamicscompressor-basic.html

Committed: https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93
Cr-Commit-Position: refs/heads/master@{#389647}

[Raymond Toy, 2016-03-21 16:41:34]

Description was changed from

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html updated
==========

to

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

[Raymond Toy, 2016-04-19 20:38:32]

Description was changed from

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

to

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9B...

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

[Raymond Toy, 2016-04-19 20:39:30]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2016-04-19 20:39:31]

PTAL.

Intent hasn't been approved yet, but it looks likely.

[hongchan, 2016-04-20 16:25:02]

lgtm with nits.

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html
(right):

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html:47: if
(Math.abs(compressor.attack.value - 0.003) < 2.61e-11)
Please add comments what this number means.

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
(right):

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h:48:
AudioParamHandler& release);
|git cl format| does this? Just curious.

[Raymond Toy, 2016-04-20 16:28:56]

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html
(right):

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html:47: if
(Math.abs(compressor.attack.value - 0.003) < 2.61e-11)
On 2016/04/20 16:25:02, hoch wrote:
> Please add comments what this number means.

Which number?

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
(right):

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h:48:
AudioParamHandler& release);
On 2016/04/20 16:25:02, hoch wrote:
> |git cl format| does this? Just curious.

I don't think so.  But there are so many parameters, that I found it easier to
read with one parameter per line, especially since the parameter type name is
long.

[hongchan, 2016-04-21 17:32:33]

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html
(right):

https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html:47: if
(Math.abs(compressor.attack.value - 0.003) < 2.61e-11)
On 2016/04/20 16:28:55, Raymond Toy wrote:
> On 2016/04/20 16:25:02, hoch wrote:
> > Please add comments what this number means.
> 
> Which number?

Why did you change 3e-8 to 2.61e-11?

[Raymond Toy, 2016-04-21 17:48:48]

On 2016/04/21 17:32:33, hoch wrote:
>
https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html
> (right):
> 
>
https://codereview.chromium.org/1807583002/diff/60001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-basic.html:47: if
> (Math.abs(compressor.attack.value - 0.003) < 2.61e-11)
> On 2016/04/20 16:28:55, Raymond Toy wrote:
> > On 2016/04/20 16:25:02, hoch wrote:
> > > Please add comments what this number means.
> > 
> > Which number?
> 
> Why did you change 3e-8 to 2.61e-11?

Because that's a tighter requirement.  Plus the original test was just plain
wrong, which I've fixed here and in line 52.

[hongchan, 2016-04-21 17:49:21]

lgtm

[Raymond Toy, 2016-04-21 17:58:45]

The CQ bit was checked by rtoy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 17:59:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807583002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807583002/80001

[commit-bot: I haz the power, 2016-04-21 19:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 19:49:03]

Dry run: This issue passed the CQ dry run.

[Raymond Toy, 2016-04-25 16:12:45]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-04-25 16:12:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1807583002/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2016-04-25 16:13:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807583002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807583002/80001

[commit-bot: I haz the power, 2016-04-25 18:00:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 18:00:59]

Failed to commit the patch.

[commit-bot: I haz the power, 2016-04-25 18:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[Raymond Toy, 2016-04-25 20:23:12]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:23:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807583002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807583002/80001

[commit-bot: I haz the power, 2016-04-25 20:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 20:30:08]

Failed to commit the patch.

[Raymond Toy, 2016-04-25 20:33:17]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2016-04-25 20:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/1807583002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2016-04-25 20:34:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1807583002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1807583002/100001

[commit-bot: I haz the power, 2016-04-26 01:02:56]

Description was changed from

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9B...

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

to

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9B...

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

[commit-bot: I haz the power, 2016-04-26 01:02:57]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-04-26 01:04:11]

Description was changed from

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9B...

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html
==========

to

==========
DynamicsCompressor.reduction is a float not an AudioParam

The WebAudio spec says the reduction attribute is a read-only float,
not an AudioParam.  Make it so.

See http://webaudio.github.io/web-audio-api/#attributes-25
WebAudio issue: https://github.com/WebAudio/web-audio-api/issues/243
Resolution: https://github.com/WebAudio/web-audio-api/pull/404

Intent:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/_Rl4IviXanE/vaoTC-9B...

BUG=595022
TEST=dynamicscompressor-clear-internal-state.html,
dynamicscompressor-simple.html, dynamicscompressor-basic.html

Committed: https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93
Cr-Commit-Position: refs/heads/master@{#389647}
==========

[commit-bot: I haz the power, 2016-04-26 01:04:13]

Patchset 6 (id:??) landed as
https://crrev.com/b55aa6bd0a936c03d572d9e09b5e07db16b7da93
Cr-Commit-Position: refs/heads/master@{#389647}