Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html

Issue 1807583002: DynamicsCompressor.reduction is a float not an AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html b/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html
index 88b486a2f4c076c24ba5565098f729bfa656a591..65a33b29f1f28e028ff86398c6950cb7bc9f849f 100644
--- a/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html
+++ b/third_party/WebKit/LayoutTests/webaudio/dynamicscompressor-simple.html
@@ -13,6 +13,7 @@
<script>
description("Test pre-emphasis in DynamicsCompressor is removed");
var context;
+ var compressor;
var sampleRate = 44100;
var lengthInSeconds = 1;
var renderedData;
@@ -43,15 +44,14 @@
+ " (expected >= " + peakThreshold + ")");
}
+ if (compressor.reduction)
+ testPassed("Reduction value changed as expected.")
+ else
+ testFailed("Reduction value is still the default value of 0.");
finishJSTest();
}
function runTest() {
- if (!window.testRunner) {
- testRunner.dumpAsTest();
- testRunner.waitUntilDone();
- }
-
window.jsTestIsAsync = true;
context = new OfflineAudioContext(1, sampleRate * lengthInSeconds, sampleRate);
@@ -64,7 +64,7 @@
osc.frequency.value = 15000;
var gain = context.createGain();
gain.gain.value = 1.5;
- var compressor = context.createDynamicsCompressor();
+ compressor = context.createDynamicsCompressor();
osc.connect(gain);
gain.connect(compressor);
compressor.connect(context.destination);

Powered by Google App Engine
This is Rietveld 408576698