Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h

Issue 1807583002: DynamicsCompressor.reduction is a float not an AudioParam (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
index 7c1f64d0c1856257cea0c1ea555793373e4adc82..a098272ede2d6030b5c7b26be9cd2a65ae31411c 100644
--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.h
@@ -38,7 +38,15 @@ class DynamicsCompressor;
class MODULES_EXPORT DynamicsCompressorHandler final : public AudioHandler {
public:
- static PassRefPtr<DynamicsCompressorHandler> create(AudioNode&, float sampleRate, AudioParamHandler& threshold, AudioParamHandler& knee, AudioParamHandler& ratio, AudioParamHandler& reduction, AudioParamHandler& attack, AudioParamHandler& release);
+ static PassRefPtr<DynamicsCompressorHandler> create(
+ AudioNode&,
+ float sampleRate,
+ AudioParamHandler& threshold,
+ AudioParamHandler& knee,
+ AudioParamHandler& ratio,
+ AudioParamHandler& attack,
+ AudioParamHandler& release);
+
~DynamicsCompressorHandler();
// AudioHandler
@@ -46,8 +54,16 @@ public:
void initialize() override;
void clearInternalStateWhenDisabled() override;
+ float reductionValue() const { return m_reduction; }
private:
- DynamicsCompressorHandler(AudioNode&, float sampleRate, AudioParamHandler& threshold, AudioParamHandler& knee, AudioParamHandler& ratio, AudioParamHandler& reduction, AudioParamHandler& attack, AudioParamHandler& release);
+ DynamicsCompressorHandler(
+ AudioNode&,
+ float sampleRate,
+ AudioParamHandler& threshold,
+ AudioParamHandler& knee,
+ AudioParamHandler& ratio,
+ AudioParamHandler& attack,
+ AudioParamHandler& release);
double tailTime() const override;
double latencyTime() const override;
@@ -55,7 +71,7 @@ private:
RefPtr<AudioParamHandler> m_threshold;
RefPtr<AudioParamHandler> m_knee;
RefPtr<AudioParamHandler> m_ratio;
- RefPtr<AudioParamHandler> m_reduction;
+ float m_reduction;
RefPtr<AudioParamHandler> m_attack;
RefPtr<AudioParamHandler> m_release;
@@ -71,7 +87,7 @@ public:
AudioParam* threshold() const;
AudioParam* knee() const;
AudioParam* ratio() const;
- AudioParam* reduction() const;
+ float reduction() const;
AudioParam* attack() const;
AudioParam* release() const;
@@ -82,7 +98,6 @@ private:
Member<AudioParam> m_threshold;
Member<AudioParam> m_knee;
Member<AudioParam> m_ratio;
- Member<AudioParam> m_reduction;
Member<AudioParam> m_attack;
Member<AudioParam> m_release;

Powered by Google App Engine
This is Rietveld 408576698