src/compiler/x87/instruction-selector-x87.cc - Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/x87/instruction-selector-x87.cc

Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-phi

Patch Set: Forgot to add the visit functions on mips, ppc, and x87. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/x87/instruction-selector-x87.cc

diff --git a/src/compiler/x87/instruction-selector-x87.cc b/src/compiler/x87/instruction-selector-x87.cc

index 404d053e92f7168599391a64ba85e8b56d8464df..6076c7320e61a90c572079e3c5031794754b88c0 100644

--- a/src/compiler/x87/instruction-selector-x87.cc

+++ b/src/compiler/x87/instruction-selector-x87.cc

@@ -580,6 +580,8 @@ void InstructionSelector::VisitInt32PairSub(Node* node) {

Emit(kX87SubPair, 2, outputs, 4, inputs, 1, temps);

}

+void InstructionSelector::VisitInt32PairMul(Node* node) { UNIMPLEMENTED(); }

void InstructionSelector::VisitWord32PairShl(Node* node) {

X87OperandGenerator g(this);