src/compiler/wasm-compiler.cc - Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/wasm-compiler.cc

Issue 1807273002: [wasm] Int64Lowering of Int64Mul on ia32 and arm. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm-phi

Patch Set: Forgot to add the visit functions on mips, ppc, and x87. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/wasm-compiler.cc

diff --git a/src/compiler/wasm-compiler.cc b/src/compiler/wasm-compiler.cc

index c4bde203fa71de431a8f4c0d7382348b3928504e..1906ecadc00ab7faf4cf936f1dc4a0edc43015d7 100644

--- a/src/compiler/wasm-compiler.cc

+++ b/src/compiler/wasm-compiler.cc

@@ -502,6 +502,9 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,

op = m->Int64Sub();

break;

// kExprI64Mul:

+ case wasm::kExprI64Mul:

+ op = m->Int64Mul();

+ break;

// kExprI64DivS:

case wasm::kExprI64DivS:

return BuildI64DivS(left, right);

@@ -573,9 +576,6 @@ Node* WasmGraphBuilder::Binop(wasm::WasmOpcode opcode, Node* left,

#if WASM_64

// Opcodes only supported on 64-bit platforms.

// TODO(titzer): query the machine operator builder here instead of #ifdef.

- case wasm::kExprI64Mul:

- op = m->Int64Mul();

- break;

case wasm::kExprI64Ror:

op = m->Word64Ror();

break;