Source/core/xml/XPathNodeSet.cpp - Issue 180723006: Have ElementData::attributeItem() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathNodeSet.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/xml/XPathNodeSet.cpp

diff --git a/Source/core/xml/XPathNodeSet.cpp b/Source/core/xml/XPathNodeSet.cpp

index b0966c66301c6117f3d6a70324e2aca29c60d190..f4cb8a49e31153159a8818b049d3cd5158552fe9 100644

--- a/Source/core/xml/XPathNodeSet.cpp

+++ b/Source/core/xml/XPathNodeSet.cpp

@@ -219,7 +219,7 @@ void NodeSet::traversalSort() const

unsigned attributeCount = element->attributeCount();

for (unsigned i = 0; i < attributeCount; ++i) {

- RefPtr<Attr> attr = element->attrIfExists(element->attributeItem(i)->name());

+ RefPtr<Attr> attr = element->attrIfExists(element->attributeItem(i).name());

if (attr && nodes.contains(attr.get()))

sortedNodes.append(attr);

}

« no previous file with comments | « Source/core/page/PageSerializer.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »