Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: Source/core/xml/XPathNodeSet.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/page/PageSerializer.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 2 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 201 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 212
213 if (!containsAttributeNodes || !n->isElementNode()) 213 if (!containsAttributeNodes || !n->isElementNode())
214 continue; 214 continue;
215 215
216 Element* element = toElement(n); 216 Element* element = toElement(n);
217 if (!element->hasAttributes()) 217 if (!element->hasAttributes())
218 continue; 218 continue;
219 219
220 unsigned attributeCount = element->attributeCount(); 220 unsigned attributeCount = element->attributeCount();
221 for (unsigned i = 0; i < attributeCount; ++i) { 221 for (unsigned i = 0; i < attributeCount; ++i) {
222 RefPtr<Attr> attr = element->attrIfExists(element->attributeItem(i)- >name()); 222 RefPtr<Attr> attr = element->attrIfExists(element->attributeItem(i). name());
223 if (attr && nodes.contains(attr.get())) 223 if (attr && nodes.contains(attr.get()))
224 sortedNodes.append(attr); 224 sortedNodes.append(attr);
225 } 225 }
226 } 226 }
227 227
228 ASSERT(sortedNodes.size() == nodeCount); 228 ASSERT(sortedNodes.size() == nodeCount);
229 const_cast<Vector<RefPtr<Node> >&>(m_nodes).swap(sortedNodes); 229 const_cast<Vector<RefPtr<Node> >&>(m_nodes).swap(sortedNodes);
230 } 230 }
231 231
232 void NodeSet::reverse() 232 void NodeSet::reverse()
(...skipping 22 matching lines...) Expand all
255 Node* NodeSet::anyNode() const 255 Node* NodeSet::anyNode() const
256 { 256 {
257 if (isEmpty()) 257 if (isEmpty())
258 return 0; 258 return 0;
259 259
260 return m_nodes.at(0).get(); 260 return m_nodes.at(0).get();
261 } 261 }
262 262
263 } 263 }
264 } 264 }
OLDNEW
« no previous file with comments | « Source/core/page/PageSerializer.cpp ('k') | Source/core/xml/XPathStep.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698