Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1287)

Unified Diff: Source/core/page/PageSerializer.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/PageSerializer.cpp
diff --git a/Source/core/page/PageSerializer.cpp b/Source/core/page/PageSerializer.cpp
index c596260732a2e73218fff48592e2426e43b205eb..61a3daa111b17f45b56654c55b1dcbc445ba8601 100644
--- a/Source/core/page/PageSerializer.cpp
+++ b/Source/core/page/PageSerializer.cpp
@@ -80,9 +80,9 @@ static bool isCharsetSpecifyingNode(const Node& node)
if (element.hasAttributes()) {
unsigned attributeCount = element.attributeCount();
for (unsigned i = 0; i < attributeCount; ++i) {
- const Attribute* attribute = element.attributeItem(i);
+ const Attribute& attribute = element.attributeItem(i);
// FIXME: We should deal appropriately with the attribute if they have a namespace.
- attributes.append(std::make_pair(attribute->name().localName(), attribute->value().string()));
+ attributes.append(std::make_pair(attribute.name().localName(), attribute.value().string()));
}
}
WTF::TextEncoding textEncoding = encodingFromMetaAttributes(attributes);
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698