Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Side by Side Diff: Source/core/page/PageSerializer.cpp

Issue 180723006: Have ElementData::attributeItem() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 if (!node.isHTMLElement()) 73 if (!node.isHTMLElement())
74 return false; 74 return false;
75 75
76 const HTMLElement& element = toHTMLElement(node); 76 const HTMLElement& element = toHTMLElement(node);
77 if (!element.hasTagName(HTMLNames::metaTag)) 77 if (!element.hasTagName(HTMLNames::metaTag))
78 return false; 78 return false;
79 HTMLAttributeList attributes; 79 HTMLAttributeList attributes;
80 if (element.hasAttributes()) { 80 if (element.hasAttributes()) {
81 unsigned attributeCount = element.attributeCount(); 81 unsigned attributeCount = element.attributeCount();
82 for (unsigned i = 0; i < attributeCount; ++i) { 82 for (unsigned i = 0; i < attributeCount; ++i) {
83 const Attribute* attribute = element.attributeItem(i); 83 const Attribute& attribute = element.attributeItem(i);
84 // FIXME: We should deal appropriately with the attribute if they ha ve a namespace. 84 // FIXME: We should deal appropriately with the attribute if they ha ve a namespace.
85 attributes.append(std::make_pair(attribute->name().localName(), attr ibute->value().string())); 85 attributes.append(std::make_pair(attribute.name().localName(), attri bute.value().string()));
86 } 86 }
87 } 87 }
88 WTF::TextEncoding textEncoding = encodingFromMetaAttributes(attributes); 88 WTF::TextEncoding textEncoding = encodingFromMetaAttributes(attributes);
89 return textEncoding.isValid(); 89 return textEncoding.isValid();
90 } 90 }
91 91
92 static bool shouldIgnoreElement(const Element& element) 92 static bool shouldIgnoreElement(const Element& element)
93 { 93 {
94 return element.hasTagName(HTMLNames::scriptTag) || element.hasTagName(HTMLNa mes::noscriptTag) || isCharsetSpecifyingNode(element); 94 return element.hasTagName(HTMLNames::scriptTag) || element.hasTagName(HTMLNa mes::noscriptTag) || isCharsetSpecifyingNode(element);
95 } 95 }
(...skipping 284 matching lines...) Expand 10 before | Expand all | Expand 10 after
380 if (iter != m_blankFrameURLs.end()) 380 if (iter != m_blankFrameURLs.end())
381 return iter->value; 381 return iter->value;
382 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++); 382 String url = "wyciwyg://frame/" + String::number(m_blankFrameCounter++);
383 KURL fakeURL(ParsedURLString, url); 383 KURL fakeURL(ParsedURLString, url);
384 m_blankFrameURLs.add(frame, fakeURL); 384 m_blankFrameURLs.add(frame, fakeURL);
385 385
386 return fakeURL; 386 return fakeURL;
387 } 387 }
388 388
389 } 389 }
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorDOMAgent.cpp ('k') | Source/core/xml/XPathNodeSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698