Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1807013002: S390: [wasm] Int64Lowering of Int64Add (Closed)

Created:
4 years, 9 months ago by john.yan
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [wasm] Int64Lowering of Int64Add Original commit message: Int64Add is lowered to a new turbofan operator, Int32AddPair. The new operator takes 4 inputs an generates 2 outputs. The inputs are the low word of the left input, high word of the left input, the low word of the right input, and high word of the right input. The ouputs are the low and high word of the result of the addition. R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/06bceeb753789a2d4849f22727d775c36eea5637 Cr-Commit-Position: refs/heads/master@{#34840}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -4 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-codes-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-scheduler-s390.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M src/s390/assembler-s390.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/s390/assembler-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/disasm-s390.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807013002/1
4 years, 9 months ago (2016-03-16 20:12:01 UTC) #2
john.yan
S390: [wasm] Int64Lowering of Int64Add
4 years, 9 months ago (2016-03-16 20:18:35 UTC) #3
JoranSiu
On 2016/03/16 20:18:35, john.yan wrote: > S390: [wasm] Int64Lowering of Int64Add lgtm
4 years, 9 months ago (2016-03-16 20:20:57 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-16 20:28:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807013002/1
4 years, 9 months ago (2016-03-16 20:34:41 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:36:46 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:37:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06bceeb753789a2d4849f22727d775c36eea5637
Cr-Commit-Position: refs/heads/master@{#34840}

Powered by Google App Engine
This is Rietveld 408576698