Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.

BUG=563856
Committed: https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785
Cr-Commit-Position: refs/heads/master@{#382584}

[xlai (Olivia), 2016-03-17 15:26:06]

Patchset #1 (id:1) has been deleted

[xlai (Olivia), 2016-03-17 15:31:18]

Description was changed from

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

BUG=563856
==========

to

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.


BUG=563856
==========

[xlai (Olivia), 2016-03-17 15:31:18]

xlai@chromium.org changed reviewers:
+ junov@chromium.org

[xlai (Olivia), 2016-03-17 15:38:53]

Added the set of functions that are related to line-drawing to
OffscreenCanvasRenderingContext2D.

I tried to include as more as possible line-drawing functions in a single layout
test (including beginPath, lineWidth, lineJoin, setLineDash, stroke(Path2D),
arc, fill(CanvasFillRule)), because these functions exist in 
HTMLCanvasElement before and so testing them exhaustively may
be unnecessary.

One concern is that the enum CanvasFillRule is defined in
CanvasRenderingContext2D; but it is supposed to be shared
between it and OffscreenCanvasRenderingContext2D.
Implementation-wise, it doesn't matter because the enum is
in global scope. But design-wise, it might be a bit 
confusing.

https://codereview.chromium.org/1806943005/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl
(left):

https://codereview.chromium.org/1806943005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.idl:15:
// colors and styles (see also the CanvasDrawingStyles interface)
The interface "CanvasDrawingStyles" doesn't exist in code base; this comment
might be outdated so I remove it.

[xlai (Olivia), 2016-03-18 15:18:25]

xlai@chromium.org changed reviewers:
+ haraken@chromium.org

[xlai (Olivia), 2016-03-22 14:24:43]

Adding haraken@ as reviewers for the added runtime flag "StableBlinkFeatures",
after discussion in the email conversation thread "IDL Binding Feature Request:
Allow "Exposed" argument include non-runtime-enabled and runtime-enabled
features".

[Justin Novosad, 2016-03-22 14:34:48]

lgtm with nit

https://codereview.chromium.org/1806943005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/canvas2d/Path2D.idl (right):

https://codereview.chromium.org/1806943005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/canvas2d/Path2D.idl:36: Exposed(Worker
ExperimentalCanvasFeatures,Window StableBlinkFeatures),
space after comma.

[haraken, 2016-03-22 15:08:53]

LGTM given the discussion in the "IDL Binding Feature Request:" thread.

[xlai (Olivia), 2016-03-22 15:14:11]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2016-03-22 15:14:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/1806943005/#ps80001
(title: "Nits + rebase with master")

[commit-bot: I haz the power, 2016-03-22 15:14:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806943005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806943005/80001

[commit-bot: I haz the power, 2016-03-22 16:36:59]

Description was changed from

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.


BUG=563856
==========

to

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.


BUG=563856
==========

[commit-bot: I haz the power, 2016-03-22 16:36:59]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-03-22 16:38:23]

Description was changed from

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.


BUG=563856
==========

to

==========
Implemented/Tested line-drawing functions in OffscreenCanvas 2D Context

The new Web APIs that are implemented are:

* OffscreenCanvasRendering2D.beginPath()
* OffscreenCanvasRendering2D.fill(optional CanvasFillRule)
* OffscreenCanvasRendering2D.fill(Path2D, optional CanvasFillRule)
* OffscreenCanvasRendering2D.stroke()
* OffscreenCanvasRendering2D.stroke(Path2D)

* OffscreenCanvasRendering2D.lineWidth
* OffscreenCanvasRendering2D.lineCap
* OffscreenCanvasRendering2D.lineJoin
* OffscreenCanvasRendering2D.miterLimit

* OffscreenCanvasRendering2D.setLineDash(array);
* OffscreenCanvasRendering2D.getLineDash
* OffscreenCanvasRendering2D.lineDashOffset

A subset of existing Web APIs shared with non-Offscreen
canvas from CanvasPathMethods are also tested, including:

arc, lineTo, bezierCurveTo, moveTo, closePath.

BUG=563856

Committed: https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785
Cr-Commit-Position: refs/heads/master@{#382584}
==========

[commit-bot: I haz the power, 2016-03-22 16:38:24]

Patchset 4 (id:??) landed as
https://crrev.com/743ca082b662386b4df43a5dc556f9a1be701785
Cr-Commit-Position: refs/heads/master@{#382584}