components/autofill/content/browser/content_autofill_driver_factory.h - Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/browser/content_autofill_driver_factory.h

Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment addressed Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager_test_base.cc ('k') | components/autofill/content/browser/content_autofill_driver_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/browser/content_autofill_driver_factory.h

diff --git a/components/autofill/content/browser/content_autofill_driver_factory.h b/components/autofill/content/browser/content_autofill_driver_factory.h

index 12d36d653a276928d9a777afe4718988909ff782..1103b195f5c7d4d712c23fb35be337353c06bbe8 100644

--- a/components/autofill/content/browser/content_autofill_driver_factory.h

+++ b/components/autofill/content/browser/content_autofill_driver_factory.h

@@ -54,8 +54,8 @@ class ContentAutofillDriverFactory : public content::WebContentsObserver,

content::RenderFrameHost* render_frame_host,

const content::LoadCommittedDetails& details,

const content::FrameNavigateParams& params) override;

- void NavigationEntryCommitted(

- const content::LoadCommittedDetails& load_details) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

void WasHidden() override;

static const char kContentAutofillDriverFactoryWebContentsUserDataKey[];