Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: components/autofill/content/browser/content_autofill_driver_factory.cc

Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment addressed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/browser/content_autofill_driver_factory.cc
diff --git a/components/autofill/content/browser/content_autofill_driver_factory.cc b/components/autofill/content/browser/content_autofill_driver_factory.cc
index f8b1f80177682af80169f2130dd7af13cfffa01a..9e2cb550e9efc8212970381ef9a02a7b136b4677 100644
--- a/components/autofill/content/browser/content_autofill_driver_factory.cc
+++ b/components/autofill/content/browser/content_autofill_driver_factory.cc
@@ -10,6 +10,7 @@
#include "components/autofill/core/browser/autofill_manager.h"
#include "components/autofill/core/browser/form_structure.h"
#include "components/autofill/core/common/autofill_switches.h"
+#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
#include "ipc/ipc_message_macros.h"
@@ -95,9 +96,10 @@ void ContentAutofillDriverFactory::DidNavigateAnyFrame(
frame_driver_map_[render_frame_host]->DidNavigateFrame(details, params);
}
-void ContentAutofillDriverFactory::NavigationEntryCommitted(
- const content::LoadCommittedDetails& load_details) {
- client_->HideAutofillPopup();
+void ContentAutofillDriverFactory::DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) {
+ if (navigation_handle->HasCommitted())
+ client_->HideAutofillPopup();
}
void ContentAutofillDriverFactory::WasHidden() {
« no previous file with comments | « components/autofill/content/browser/content_autofill_driver_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698