Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8473)

Unified Diff: chrome/browser/password_manager/password_manager_test_base.cc

Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment addressed Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager_test_base.cc
diff --git a/chrome/browser/password_manager/password_manager_test_base.cc b/chrome/browser/password_manager/password_manager_test_base.cc
index 7fdb0e2e702702ad1b151ac9eac65285521e66a8..fdc641aa3a4fafef574ac7c233226b7a0275e3ce 100644
--- a/chrome/browser/password_manager/password_manager_test_base.cc
+++ b/chrome/browser/password_manager/password_manager_test_base.cc
@@ -37,6 +37,12 @@ NavigationObserver::NavigationObserver(content::WebContents* web_contents)
NavigationObserver::~NavigationObserver() {
}
+void NavigationObserver::DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) {
+ if (quit_on_entry_committed_)
+ message_loop_runner_->Quit();
+}
+
void NavigationObserver::DidFinishLoad(
content::RenderFrameHost* render_frame_host,
const GURL& validated_url) {
@@ -49,12 +55,6 @@ void NavigationObserver::DidFinishLoad(
}
}
-void NavigationObserver::NavigationEntryCommitted(
- const content::LoadCommittedDetails& load_details) {
- if (quit_on_entry_committed_)
- message_loop_runner_->Quit();
-}
-
void NavigationObserver::Wait() {
message_loop_runner_->Run();
}

Powered by Google App Engine
This is Rietveld 408576698