chrome/browser/password_manager/password_manager_test_base.h - Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/password_manager/password_manager_test_base.h

Issue 1806593002: Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autofill/content_autofill_driver_browsertest.cc ('k') | chrome/browser/password_manager/password_manager_test_base.cc » ('j') | components/autofill/content/browser/content_autofill_driver_factory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/password_manager/password_manager_test_base.h

diff --git a/chrome/browser/password_manager/password_manager_test_base.h b/chrome/browser/password_manager/password_manager_test_base.h

index b8cf4d2631aff34e54defa34ffbf9e1159b7a709..f1a5c60f4782dfa0fc4356ddc19ce069ae719b53 100644

--- a/chrome/browser/password_manager/password_manager_test_base.h

+++ b/chrome/browser/password_manager/password_manager_test_base.h

@@ -41,8 +41,8 @@ class NavigationObserver : public content::WebContentsObserver {

// content::WebContentsObserver:

void DidFinishLoad(content::RenderFrameHost* render_frame_host,

const GURL& validated_url) override;

- void NavigationEntryCommitted(

- const content::LoadCommittedDetails& load_details) override;

+ void DidFinishNavigation(

+ content::NavigationHandle* navigation_handle) override;

nasko 2016/03/16 18:20:04 very minor nit: Timewise, navigation is finished,

vabr (Chromium) 2016/03/17 15:36:29 Done.

private:

std::string wait_for_path_;