Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation

chrome/browser/password_manager/password_manager_test_base.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_
 #define CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 23 matching lines @@
 
   // Wait for navigation to succeed.
   void Wait();
 
   // Returns the RenderFrameHost that navigated.
   content::RenderFrameHost* render_frame_host() { return render_frame_host_; }
 
   // content::WebContentsObserver:
   void DidFinishLoad(content::RenderFrameHost* render_frame_host,
                      const GURL& validated_url) override;
-  void NavigationEntryCommitted(
-      const content::LoadCommittedDetails& load_details) override;
+  void DidFinishNavigation(
+      content::NavigationHandle* navigation_handle) override;

[nasko, 2016/03/16 18:20:04]

very minor nit: Timewise, navigation is finished, then document load starts,
then document load finishes. So moving this above the other method matches
logical progression.

[vabr (Chromium), 2016/03/17 15:36:29]

Done.

 
  private:
   std::string wait_for_path_;
   content::RenderFrameHost* render_frame_host_;
   bool quit_on_entry_committed_;
   scoped_refptr<content::MessageLoopRunner> message_loop_runner_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationObserver);
 };
 
@@ skipping 89 matching lines @@
 
   // Accessors
   content::WebContents* WebContents();
   content::RenderViewHost* RenderViewHost();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(PasswordManagerBrowserTestBase);
 };
 
 #endif  // CHROME_BROWSER_PASSWORD_MANAGER_PASSWORD_MANAGER_TEST_BASE_H_