Autofill & passwords: Replace NavigationEntryCommitted with DidFinishNavigation

components/autofill/content/browser/content_autofill_driver_factory.cc

Index: components/autofill/content/browser/content_autofill_driver_factory.cc
diff --git a/components/autofill/content/browser/content_autofill_driver_factory.cc b/components/autofill/content/browser/content_autofill_driver_factory.cc
index f8b1f80177682af80169f2130dd7af13cfffa01a..9e2cb550e9efc8212970381ef9a02a7b136b4677 100644
--- a/components/autofill/content/browser/content_autofill_driver_factory.cc
+++ b/components/autofill/content/browser/content_autofill_driver_factory.cc
@@ -10,6 +10,7 @@
 #include "components/autofill/core/browser/autofill_manager.h"
 #include "components/autofill/core/browser/form_structure.h"
 #include "components/autofill/core/common/autofill_switches.h"
+#include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "ipc/ipc_message_macros.h"
@@ -95,9 +96,10 @@ void ContentAutofillDriverFactory::DidNavigateAnyFrame(
   frame_driver_map_[render_frame_host]->DidNavigateFrame(details, params);
 }
 
-void ContentAutofillDriverFactory::NavigationEntryCommitted(
-    const content::LoadCommittedDetails& load_details) {
-  client_->HideAutofillPopup();
+void ContentAutofillDriverFactory::DidFinishNavigation(
+    content::NavigationHandle* navigation_handle) {
+  if (navigation_handle->HasCommitted())

[nasko, 2016/03/16 18:20:04]

Do you care if this was successful commit or an error page? If you do, you
probably want to call IsErrorPage.

[vabr (Chromium), 2016/03/17 15:36:29]

I thought about it, and whether successful or an error page, the autofill pop-up
likely no longer has the form to be shown with, so it should be hidden.

+    client_->HideAutofillPopup();
 }
 
 void ContentAutofillDriverFactory::WasHidden() {