[iOS] Define bundle_data target for //ui unittests

[iOS] Define bundle_data target for //ui unittests

This ensure that the files required by ui_base_unittests and
gfx_unittests application will be copied into the application
bundles on iOS.

BUG=297668
Committed: https://crrev.com/0e1a1b3aa52ed644e1bed2a21b72df2be793bccf
Cr-Commit-Position: refs/heads/master@{#381682}

[sdefresne, 2016-03-16 18:07:37]

sdefresne@chromium.org changed reviewers:
+ dpranke@chromium.org, oshima@chromium.org

[sdefresne, 2016-03-16 18:07:38]

dpranke: Please take a look.
oshima: Could you review as OWNERS?

[oshima, 2016-03-16 19:16:53]

hi, I'm not the owner of ui/base nor ui/gfx (unless it's about display/screen).
Please pick owner from ui/OWNERS.

[Dirk Pranke, 2016-03-16 22:06:05]

dpranke@chromium.org changed reviewers:
+ sky@chromium.org

[Dirk Pranke, 2016-03-16 22:06:06]

lgtm.

sky@, can you owners-stamp this?

https://codereview.chromium.org/1806033002/diff/1/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/1806033002/diff/1/ui/gfx/BUILD.gn#newcode641
ui/gfx/BUILD.gn:641: "test/data",
nit: trailing slash

[sky, 2016-03-16 23:56:05]

LGTM

[sdefresne, 2016-03-17 09:37:12]

On 2016/03/16 at 19:16:53, oshima wrote:
> hi, I'm not the owner of ui/base nor ui/gfx (unless it's about
display/screen). Please pick owner from ui/OWNERS.

Sorry, I don't know why "git cl owners" suggested you.

[sdefresne, 2016-03-17 09:37:18]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-03-17 09:37:19]

Thank you for the review.

https://codereview.chromium.org/1806033002/diff/1/ui/gfx/BUILD.gn
File ui/gfx/BUILD.gn (right):

https://codereview.chromium.org/1806033002/diff/1/ui/gfx/BUILD.gn#newcode641
ui/gfx/BUILD.gn:641: "test/data",
On 2016/03/16 at 22:06:05, Dirk Pranke wrote:
> nit: trailing slash

No, adding a trailing slash will cause an error as sources needs to be converted
to SourceFile (the gn object representing a path to a source file). This errors
out if the path ends with a trailing slash saying that you cannot reference a
directory.

So, here we list the directory as a single file. This means that if the content
of the directory change, then the bundle_data may be incorrect. This was
discussed when I created the design for bundles, and the decision was that for
tests we were okay with having dependencies a bit stale as generally adding a
new test data will go in sync with new source change, and cause the target to be
rebuilt (as the create_bundle target transitively depends on the same target as
the executable target).

[commit-bot: I haz the power, 2016-03-17 09:37:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1806033002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1806033002/1

[commit-bot: I haz the power, 2016-03-17 10:13:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-17 10:14:07]

Description was changed from

==========
[iOS] Define bundle_data target for //ui unittests

This ensure that the files required by ui_base_unittests and
gfx_unittests application will be copied into the application
bundles on iOS.

BUG=297668
==========

to

==========
[iOS] Define bundle_data target for //ui unittests

This ensure that the files required by ui_base_unittests and
gfx_unittests application will be copied into the application
bundles on iOS.

BUG=297668

Committed: https://crrev.com/0e1a1b3aa52ed644e1bed2a21b72df2be793bccf
Cr-Commit-Position: refs/heads/master@{#381682}
==========

[commit-bot: I haz the power, 2016-03-17 10:14:07]

Patchset 1 (id:??) landed as
https://crrev.com/0e1a1b3aa52ed644e1bed2a21b72df2be793bccf
Cr-Commit-Position: refs/heads/master@{#381682}