Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Issue 1807213002: [iOS] Mark test bundle_data targets as testonly. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke, Nico
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ui
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Mark test bundle_data targets as testonly. Mark bundle_data targets used only for tests targets as testonly to prevent linking them in production applications. BUG=297668 Committed: https://crrev.com/fd1d03940f23c3a90b4c9d47a0bb4ee22059885e Cr-Commit-Position: refs/heads/master@{#382199}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M base/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/resources/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
sdefresne
Please take a look.
4 years, 9 months ago (2016-03-17 13:00:41 UTC) #2
sdefresne
+dpranke: Please take a look.
4 years, 9 months ago (2016-03-17 17:58:59 UTC) #4
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-18 02:03:19 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807213002/20001
4 years, 9 months ago (2016-03-18 10:16:12 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-18 11:19:28 UTC) #9
sdefresne
thakis: ping?
4 years, 9 months ago (2016-03-18 16:17:21 UTC) #10
Nico
lgtm Sorry, was afk earlier this week.
4 years, 9 months ago (2016-03-18 18:36:44 UTC) #11
sdefresne
On 2016/03/18 at 18:36:44, thakis wrote: > lgtm > > Sorry, was afk earlier this ...
4 years, 9 months ago (2016-03-19 13:18:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1807213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1807213002/20001
4 years, 9 months ago (2016-03-19 13:18:54 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-19 14:20:53 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 14:22:04 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd1d03940f23c3a90b4c9d47a0bb4ee22059885e
Cr-Commit-Position: refs/heads/master@{#382199}

Powered by Google App Engine
This is Rietveld 408576698