Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: ui/base/BUILD.gn

Issue 1806033002: [iOS] Define bundle_data target for //ui unittests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@google_apis
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/BUILD.gn » ('j') | ui/gfx/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/BUILD.gn
diff --git a/ui/base/BUILD.gn b/ui/base/BUILD.gn
index e2a30a86e2414483b2d2919e66ee6c5f9bac9a23..341b7e6e73696a4c3dc1ce5116cd139b3fa23740 100644
--- a/ui/base/BUILD.gn
+++ b/ui/base/BUILD.gn
@@ -702,6 +702,16 @@ if (is_android) {
}
}
+bundle_data("ui_base_unittests_bundle_data") {
+ sources = [
+ "test/data/data_pack_unittest/truncated-header.pak",
+ ]
+ outputs = [
+ "{{bundle_resources_dir}}/" +
+ "{{source_root_relative_dir}}/{{source_file_part}}",
+ ]
+}
+
# GYP version: ui/base/ui_base_tests.gyp:ui_base_unittests
test("ui_base_unittests") {
sources = [
@@ -799,6 +809,7 @@ test("ui_base_unittests") {
configs += [ "//build/config/compiler:no_size_t_to_int_warning" ]
deps = [
+ ":ui_base_unittests_bundle_data",
"//base",
"//base/test:test_support",
"//net",
@@ -818,14 +829,14 @@ test("ui_base_unittests") {
"//url",
]
- if (is_ios) {
- # TODO(GYP) lots of iOS-only steps for ui_base_unittests
- }
-
if (build_ime) {
deps += [ "//ui/base/ime" ]
}
+ if (is_ios) {
+ deps += [ "//ui/resources:ui_test_pak_bundle_data" ]
+ }
+
if (is_win) {
sources += [
"dragdrop/os_exchange_data_win_unittest.cc",
« no previous file with comments | « no previous file | ui/gfx/BUILD.gn » ('j') | ui/gfx/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698