Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1805663002: Move core/include/fpdfapi/fpdf_page.h to correct locations. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move core/include/fpdfapi/fpdf_page.h to correct locations. This CL splits the fpdf_page.h header into the individual classes and moves them to the correct core/fpdfapi locations. R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/455a4199482324c888ea5892c660da354435c091

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -523 lines) Patch
M BUILD.gn View 3 chunks +11 lines, -2 lines 0 comments Download
A + core/fpdfapi/fpdf_edit/cpdf_pagecontentgenerator.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
D core/fpdfapi/fpdf_edit/fpdf_edit_content.cpp View 1 chunk +0 lines, -161 lines 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_doc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_edit/fpdf_edit_image.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_edit/include/cpdf_creator.h View 1 chunk +0 lines, -1 line 0 comments Download
A core/fpdfapi/fpdf_edit/include/cpdf_pagecontentgenerator.h View 1 chunk +42 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_charset.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 chunk +0 lines, -1 line 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_form.cpp View 1 chunk +65 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_pageobjectholder.cpp View 1 chunk +73 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_pageobjectlist.h View 1 chunk +21 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_pageobjectlist.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/cpdf_parseoptions.h View 1 chunk +22 lines, -0 lines 0 comments Download
A + core/fpdfapi/fpdf_page/cpdf_parseoptions.cpp View 1 chunk +6 lines, -11 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page.cpp View 4 chunks +2 lines, -131 lines 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 2 chunks +1 line, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_parser_old.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_path.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
A core/fpdfapi/fpdf_page/include/cpdf_form.h View 1 chunk +44 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/include/cpdf_page.h View 1 chunk +57 lines, -0 lines 0 comments Download
A core/fpdfapi/fpdf_page/include/cpdf_pageobjectholder.h View 1 chunk +67 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_page/pageint.h View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M core/fpdfapi/fpdf_render/include/cpdf_progressiverenderer.h View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_annot.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M core/fpdfdoc/doc_bookmark.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_formcontrol.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_link.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfdoc/doc_tagged.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdftext/fpdf_text_int.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/fpdftext/fpdf_text_int.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdftext/include/ipdf_textpage.h View 1 chunk +0 lines, -1 line 0 comments Download
D core/include/fpdfapi/fpdf_page.h View 1 chunk +0 lines, -169 lines 0 comments Download
M fpdfsdk/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/formfiller/FFL_CBA_Fontmap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/FFL_FormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/formfiller/FFL_IFormFiller.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_flatten.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdf_progressive.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdf_transformpage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfdoc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdfeditpage.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M fpdfsdk/fpdfformfill.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fpdftext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdfview.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_annothandler.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_baseform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fsdk_mgr.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/fxedit/fxet_pageobjs.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/javascript/Field.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_FontMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Icon.cpp View 1 chunk +1 line, -1 line 0 comments Download
M pdfium.gyp View 3 chunks +11 lines, -2 lines 0 comments Download
M xfa/fxfa/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
dsinclair
PTAL.
4 years, 9 months ago (2016-03-15 20:55:31 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-15 21:44:52 UTC) #3
dsinclair
4 years, 9 months ago (2016-03-16 13:49:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
455a4199482324c888ea5892c660da354435c091 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698