Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 1805343004: (Only) poison unmarked heap objects prior to sweeping. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Only) poison unmarked heap objects prior to sweeping. Drop the unnecessary restriction that eagerly finalized objects aren't allowed to touch access other eagerly finalized, but live, objects during finalization. They're allowed to access live objects in other heaps/arenas, so the same-heap restriction makes little sense. Simplify the HeapPage poisoning methods as a result. R=haraken BUG=594129 Committed: https://crrev.com/0e0025da360e1f9793712c9c772fb76e1b4c2160 Cr-Commit-Position: refs/heads/master@{#381554}

Patch Set 1 #

Patch Set 2 : remove dated assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -63 lines) Patch
M third_party/WebKit/Source/platform/heap/BlinkGC.h View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapPage.cpp View 1 4 chunks +9 lines, -35 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 2 chunks +7 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
sof
please take a look.
4 years, 9 months ago (2016-03-16 19:06:14 UTC) #3
haraken
LGTM. Nice clean-up!
4 years, 9 months ago (2016-03-16 21:31:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1805343004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1805343004/20001
4 years, 9 months ago (2016-03-16 21:35:46 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-16 21:41:43 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 21:43:58 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0e0025da360e1f9793712c9c772fb76e1b4c2160
Cr-Commit-Position: refs/heads/master@{#381554}

Powered by Google App Engine
This is Rietveld 408576698