Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: third_party/WebKit/Source/platform/heap/HeapPage.h

Issue 1805343004: (Only) poison unmarked heap objects prior to sweeping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove dated assert Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/HeapPage.h
diff --git a/third_party/WebKit/Source/platform/heap/HeapPage.h b/third_party/WebKit/Source/platform/heap/HeapPage.h
index 889503069929b4cff7593984e0da9b426f5efb71..bb54094a1d36f75d643424a1a8c381a2b14357a1 100644
--- a/third_party/WebKit/Source/platform/heap/HeapPage.h
+++ b/third_party/WebKit/Source/platform/heap/HeapPage.h
@@ -378,7 +378,7 @@ public:
virtual void invalidateObjectStartBitmap() = 0;
#if defined(ADDRESS_SANITIZER)
- virtual void poisonObjects(BlinkGC::ObjectsToPoison, BlinkGC::Poisoning) = 0;
+ virtual void poisonUnmarkedObjects() = 0;
#endif
// Check if the given address points to an object in this
// heap page. If so, find the start of that object and mark it
@@ -469,7 +469,7 @@ public:
void makeConsistentForMutator() override;
void invalidateObjectStartBitmap() override { m_objectStartBitMapComputed = false; }
#if defined(ADDRESS_SANITIZER)
- void poisonObjects(BlinkGC::ObjectsToPoison, BlinkGC::Poisoning) override;
+ void poisonUnmarkedObjects() override;
#endif
void checkAndMarkPointer(Visitor*, Address) override;
void markOrphaned() override;
@@ -526,7 +526,7 @@ public:
void makeConsistentForMutator() override;
void invalidateObjectStartBitmap() override { }
#if defined(ADDRESS_SANITIZER)
- void poisonObjects(BlinkGC::ObjectsToPoison, BlinkGC::Poisoning) override;
+ void poisonUnmarkedObjects() override;
#endif
void checkAndMarkPointer(Visitor*, Address) override;
void markOrphaned() override;
@@ -678,7 +678,7 @@ public:
void prepareHeapForTermination();
void prepareForSweep();
#if defined(ADDRESS_SANITIZER)
- void poisonArena(BlinkGC::ObjectsToPoison, BlinkGC::Poisoning);
+ void poisonArena();
#endif
Address lazySweep(size_t, size_t gcInfoIndex);
void sweepUnsweptPage();
« no previous file with comments | « third_party/WebKit/Source/platform/heap/BlinkGC.h ('k') | third_party/WebKit/Source/platform/heap/HeapPage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698