[Extensions] Allow overriding a nested options page for opening a new instance

[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253
Committed: https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442
Cr-Commit-Position: refs/heads/master@{#381555}

[Devlin, 2016-03-16 16:07:03]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[Devlin, 2016-03-16 16:07:03]

Istiaque, can you take a look?

[lazyboy, 2016-03-16 17:51:50]

lgtm
CL description is pointing to an incorrect bug, did you mean 595253?

[Devlin, 2016-03-16 18:35:08]

Description was changed from

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=594055
==========

to

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253
==========

[Devlin, 2016-03-16 20:27:28]

On 2016/03/16 17:51:50, lazyboy wrote:
> lgtm
> CL description is pointing to an incorrect bug, did you mean 595253?

Whoops, yes.  Must have copy-pasted from the wrong tab.  Good catch!

[Devlin, 2016-03-16 20:27:31]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-16 20:27:31]

The patchset sent to the CQ was uploaded after l-g-t-m from lazyboy@chromium.org
Link to the patchset: https://codereview.chromium.org/1805013005/#ps20001
(title: "missing files")

[commit-bot: I haz the power, 2016-03-16 20:28:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1805013005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1805013005/20001

[commit-bot: I haz the power, 2016-03-16 21:42:36]

Description was changed from

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253
==========

to

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253
==========

[commit-bot: I haz the power, 2016-03-16 21:42:37]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-16 21:43:58]

Description was changed from

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253
==========

to

==========
[Extensions] Allow overriding a nested options page for opening a new instance

If there is an existing chrome://extensions page open, it should be able to be
overridden to show an extension's options page if that options page opens in
a view in the chrome://extensions page.

BUG=595253

Committed: https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442
Cr-Commit-Position: refs/heads/master@{#381555}
==========

[commit-bot: I haz the power, 2016-03-16 21:44:00]

Patchset 2 (id:??) landed as
https://crrev.com/6ef722eae199b14ba8b6670568647b0905099442
Cr-Commit-Position: refs/heads/master@{#381555}