chrome/test/data/extensions/options_page_in_view/manifest.json - Issue 1805013005: [Extensions] Allow overriding a nested options page for opening a new instance

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/options_page_in_view/manifest.json

Issue 1805013005: [Extensions] Allow overriding a nested options page for opening a new instance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing files Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util_browsertest.cc ('k') | chrome/test/data/extensions/options_page_in_view/options.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "name": "Extension With Options Page",	2 "name": "Extension With Options Page",

3 "description": "An extension with an options page and an extra page",	3 "description": "An extension with an options page and an extra page",

4 "options_ui": { "page": "options.html", "open_in_tab": true },	4 "options_ui": { "page": "options.html", "open_in_tab": false },

5 "version": "0.1.1",	5 "version": "0.1.1",

6 "manifest_version": 2	6 "manifest_version": 2

7 }	7 }

OLD	NEW