chrome/test/data/extensions/options_page_in_view/manifest.json - Issue 1805013005: [Extensions] Allow overriding a nested options page for opening a new instance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/options_page_in_view/manifest.json

Issue 1805013005: [Extensions] Allow overriding a nested options page for opening a new instance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missing files Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util_browsertest.cc ('k') | chrome/test/data/extensions/options_page_in_view/options.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/options_page_in_view/manifest.json

diff --git a/chrome/test/data/extensions/options_page/manifest.json b/chrome/test/data/extensions/options_page_in_view/manifest.json

similarity index 71%

copy from chrome/test/data/extensions/options_page/manifest.json

copy to chrome/test/data/extensions/options_page_in_view/manifest.json

index 27d7bd770736acb8e0fe61d8ecec74d485f3bf06..1331309f6e9027cd2d6f378c611851c049d6a403 100644

--- a/chrome/test/data/extensions/options_page/manifest.json

+++ b/chrome/test/data/extensions/options_page_in_view/manifest.json

@@ -1,7 +1,7 @@

{

"name": "Extension With Options Page",

"description": "An extension with an options page and an extra page",

- "options_ui": { "page": "options.html", "open_in_tab": true },

+ "options_ui": { "page": "options.html", "open_in_tab": false },

"version": "0.1.1",

"manifest_version": 2

}