Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2915)

Issue 1804963002: [builtins] Fix Array.prototype.concat bug (Closed)

Created:
4 years, 4 months ago by Camillo Bruni
Modified:
4 years, 4 months ago
Reviewers:
Toon Verwaest
CC:
Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fix Array.prototype.concat bug Array.prototype.concat did not work correct with complex elements on the receiver or the prototype chain. BUG=chromium:594574 LOG=y Committed: https://crrev.com/96a2bd8ae8c25e2acbe63319011cbb829b59e3df Cr-Commit-Position: refs/heads/master@{#34798}

Patch Set 1 #

Patch Set 2 : addressing nits and reverting to old scheme #

Total comments: 1

Patch Set 3 : polishing corner cases and making tests work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -58 lines) Patch
M src/builtins.cc View 1 2 12 chunks +51 lines, -38 lines 0 comments Download
M src/elements.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/elements.cc View 1 5 chunks +42 lines, -0 lines 0 comments Download
M test/mjsunit/array-concat.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/es6/array-concat.js View 1 1 chunk +12 lines, -20 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-594574-concat-leak-1.js View 1 chunk +36 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-594574-concat-leak-2.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (10 generated)
Camillo Bruni
PTAL
4 years, 4 months ago (2016-03-15 13:37:17 UTC) #2
Toon Verwaest
You missed slow string wrappers in elements.cc. Also line 1421 in builtins.cc is a slightly ...
4 years, 4 months ago (2016-03-15 16:15:39 UTC) #3
Toon Verwaest
lgtm with one comment. https://codereview.chromium.org/1804963002/diff/20001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/1804963002/diff/20001/src/builtins.cc#newcode1096 src/builtins.cc:1096: if (!HasOnlySimpleElements(isolate, *receiver)) { I'd ...
4 years, 4 months ago (2016-03-15 19:10:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804963002/40001
4 years, 4 months ago (2016-03-15 20:07:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804963002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804963002/40001
4 years, 4 months ago (2016-03-15 20:08:18 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-03-15 20:28:21 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-03-15 20:29:38 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96a2bd8ae8c25e2acbe63319011cbb829b59e3df
Cr-Commit-Position: refs/heads/master@{#34798}

Powered by Google App Engine
This is Rietveld 408576698