src/elements.h - Issue 1804963002: [builtins] Fix Array.prototype.concat bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/elements.h

Issue 1804963002: [builtins] Fix Array.prototype.concat bug (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: polishing corner cases and making tests work Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/elements.h

diff --git a/src/elements.h b/src/elements.h

index 386fe573c7c9f776a01a13a69cd63078e5736bf1..0d06021deff03675e06bb5b4827f3c19cc9e5f63 100644

--- a/src/elements.h

+++ b/src/elements.h

@@ -55,6 +55,7 @@ class ElementsAccessor {

virtual Handle<Object> Get(Handle<JSObject> holder, uint32_t entry) = 0;

virtual PropertyDetails GetDetails(JSObject* holder, uint32_t entry) = 0;

+ virtual bool HasAccessors(JSObject* holder) = 0;

// Modifies the length data property as specified for JSArrays and resizes the

// underlying backing store accordingly. The method honors the semantics of

« no previous file with comments | « src/builtins.cc ('k') | src/elements.cc » ('j') | no next file with comments »