Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1804353002: [mojo-edk] Switch shared buffers to use Mach on OSX. (Closed)

Created:
4 years, 9 months ago by Anand Mistry (off Chromium)
Modified:
4 years, 9 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo-mach-ports
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[mojo-edk] Switch shared buffers to use Mach on OSX. BUG=582468 Committed: https://crrev.com/7fffb56f8566329795e8fc744198b119c24460ab Cr-Commit-Position: refs/heads/master@{#381785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M mojo/edk/embedder/platform_shared_buffer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/edk/system/shared_buffer_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 1712143002 Patch 320001

Messages

Total messages: 12 (5 generated)
Anand Mistry (off Chromium)
4 years, 9 months ago (2016-03-16 04:48:43 UTC) #2
Ken Rockot(use gerrit already)
! LGTM
4 years, 9 months ago (2016-03-16 04:49:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804353002/1
4 years, 9 months ago (2016-03-17 17:27:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/190533)
4 years, 9 months ago (2016-03-17 19:15:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1804353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1804353002/1
4 years, 9 months ago (2016-03-17 19:19:43 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 20:18:12 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 20:19:00 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/7fffb56f8566329795e8fc744198b119c24460ab
Cr-Commit-Position: refs/heads/master@{#381785}

Powered by Google App Engine
This is Rietveld 408576698