mojo/edk/system/shared_buffer_unittest.cc - Issue 1804353002: [mojo-edk] Switch shared buffers to use Mach on OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/system/shared_buffer_unittest.cc

Issue 1804353002: [mojo-edk] Switch shared buffers to use Mach on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-mach-ports

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/system/shared_buffer_unittest.cc

diff --git a/mojo/edk/system/shared_buffer_unittest.cc b/mojo/edk/system/shared_buffer_unittest.cc

index c699d9da3fd2de3e08cf2d290739689d5f442c83..210c2f55f0f16dc6274e35d3339cbbd1e82dd729 100644

--- a/mojo/edk/system/shared_buffer_unittest.cc

+++ b/mojo/edk/system/shared_buffer_unittest.cc

@@ -216,8 +216,10 @@ DEFINE_TEST_CLIENT_TEST_WITH_PIPE(ReceiveAndEditBufferParent, SharedBufferTest,

END_CHILD()

}

-#if defined(OS_ANDROID)

+#if defined(OS_ANDROID) || defined(OS_MACOSX)

// Android multi-process tests are not executing the new process. This is flaky.

+// Passing shared memory handles between cousins is not currently supported on

+// OSX.

#define MAYBE_PassHandleBetweenCousins DISABLED_PassHandleBetweenCousins

#else

#define MAYBE_PassHandleBetweenCousins PassHandleBetweenCousins

« no previous file with comments | « mojo/edk/embedder/platform_shared_buffer.cc ('k') | no next file » | no next file with comments »