mojo/edk/embedder/platform_shared_buffer.cc - Issue 1804353002: [mojo-edk] Switch shared buffers to use Mach on OSX.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/edk/embedder/platform_shared_buffer.cc

Issue 1804353002: [mojo-edk] Switch shared buffers to use Mach on OSX. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@mojo-mach-ports

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mojo/edk/embedder/platform_shared_buffer.cc

diff --git a/mojo/edk/embedder/platform_shared_buffer.cc b/mojo/edk/embedder/platform_shared_buffer.cc

index f3f9b70bc282861a49994c87f88f95218cb49058..614b19c0c0d4884d651e1bd1117fcf5062813636 100644

--- a/mojo/edk/embedder/platform_shared_buffer.cc

+++ b/mojo/edk/embedder/platform_shared_buffer.cc

@@ -175,8 +175,7 @@ bool PlatformSharedBuffer::Init() {

base::SharedMemoryCreateOptions options;

options.size = num_bytes_;

#if defined(OS_MACOSX) && !defined(OS_IOS)

- // TODO(crbug.com/582468): Support Mach shared memory.

- options.type = base::SharedMemoryHandle::POSIX;

+ options.type = base::SharedMemoryHandle::MACH;

#endif

shared_memory_.reset(new base::SharedMemory);

« no previous file with comments | « no previous file | mojo/edk/system/shared_buffer_unittest.cc » ('j') | no next file with comments »