Add support for new pnacl native toolchain driver

Add support for new pnacl native toolchain driver

Added new NACL_ARCH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249

Committed: https://chromium.googlesource.com/webports/+/c41b9360d4feb347893d7ed3753561a01f80f355

[Ankur Mittal, 2016-03-15 23:43:13]

Description was changed from

==========
Added new NACL_ARH=le32 to build with new driver
Added support for clang exceptions
BUG=249
==========

to

==========
Added new NACL_ARH=le32 to build with new driver
Added support for clang exceptions
BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-03-15 23:51:58]

anmittal@chromium.org changed reviewers:
+ mseaborn@chromium.org, phosek@chromium.org, smklein@chromium.org

[Ankur Mittal, 2016-03-21 21:32:42]

Description was changed from

==========
Added new NACL_ARH=le32 to build with new driver
Added support for clang exceptions
BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Add support for new pnacl native toolchain driver

- Added new NACL_ARH=le32 to build with new driver
- Added support for clang exceptions
- Disabling some packages which are disabled for old driver

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-04-04 20:26:47]

PTAL

[Ankur Mittal, 2016-04-11 23:09:24]

anmittal@chromium.org changed reviewers:
+ bradnelson@chromium.org

[Ankur Mittal, 2016-04-29 21:36:34]

Description was changed from

==========
Add support for new pnacl native toolchain driver

- Added new NACL_ARH=le32 to build with new driver
- Added support for clang exceptions
- Disabling some packages which are disabled for old driver

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Add support for new pnacl native toolchain driver

Added new NACL_ARH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[Ankur Mittal, 2016-05-02 17:28:21]

PTAL

[bradnelson, 2016-05-02 17:38:26]

Description was changed from

==========
Add support for new pnacl native toolchain driver

Added new NACL_ARH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Add support for new pnacl native toolchain driver

Added new NACL_ARCH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

[bradnelson, 2016-05-02 17:38:59]

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/build.sh
File ports/devenv/build.sh (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/build.sh#...
ports/devenv/build.sh:196: #if [[ -n ${BUILDBOT_BUILDERNAME:-} ]]; then
Can you instead just gate this out for the new arch?

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/tests/dev...
File ports/devenv/tests/devenv_small_test.js (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/tests/dev...
ports/devenv/tests/devenv_small_test.js:80: var NACL_BOOT_ARCH =
self.params["NACL_BOOT_ARCH"]
semicolon.

https://codereview.chromium.org/1804293003/diff/490001/ports/devil/build.sh
File ports/devil/build.sh (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devil/build.sh#n...
ports/devil/build.sh:5: NACLPORTS_CPPFLAGS+="${NACL_EXCEPTIONS_FLAG}"
Maybe have a space in-between on all of these? This assumes NACL_CPPFLAGS is
empty.

[Ankur Mittal, 2016-05-02 20:22:15]

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/build.sh
File ports/devenv/build.sh (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/build.sh#...
ports/devenv/build.sh:196: #if [[ -n ${BUILDBOT_BUILDERNAME:-} ]]; then
On 2016/05/02 17:38:58, bradnelson wrote:
> Can you instead just gate this out for the new arch?

Done.

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/tests/dev...
File ports/devenv/tests/devenv_small_test.js (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devenv/tests/dev...
ports/devenv/tests/devenv_small_test.js:80: var NACL_BOOT_ARCH =
self.params["NACL_BOOT_ARCH"]
On 2016/05/02 17:38:58, bradnelson wrote:
> semicolon.

Done.

https://codereview.chromium.org/1804293003/diff/490001/ports/devil/build.sh
File ports/devil/build.sh (right):

https://codereview.chromium.org/1804293003/diff/490001/ports/devil/build.sh#n...
ports/devil/build.sh:5: NACLPORTS_CPPFLAGS+="${NACL_EXCEPTIONS_FLAG}"
On 2016/05/02 17:38:58, bradnelson wrote:
> Maybe have a space in-between on all of these? This assumes NACL_CPPFLAGS is
> empty.

Done.

[Ankur Mittal, 2016-05-04 21:50:57]

PTAL

[bradnelson, 2016-05-05 05:56:46]

lgtm

This change is extremely large. Chopping it up might have been nice, but I
realize adding an new arch is cross-cutting, so I'll sign-off.
But something to keep in mind. :-)

This is pretty neat by the way!

[bradnelson, 2016-05-05 05:56:54]

The CQ bit was checked by bradnelson@chromium.org

[commit-bot: I haz the power, 2016-05-05 05:57:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1804293003/510001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1804293003/510001

[commit-bot: I haz the power, 2016-05-05 10:41:29]

Description was changed from

==========
Add support for new pnacl native toolchain driver

Added new NACL_ARCH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249
==========

to

==========
Add support for new pnacl native toolchain driver

Added new NACL_ARCH=le32 to build with new driver, added support for clang
exceptions, patched ports to build with this new driver.

BUG=https://bugs.chromium.org/p/webports/issues/detail?id=249

Committed:
https://chromium.googlesource.com/webports/+/c41b9360d4feb347893d7ed3753561a0...
==========

[commit-bot: I haz the power, 2016-05-05 10:41:30]

Committed patchset #27 (id:510001) as
https://chromium.googlesource.com/webports/+/c41b9360d4feb347893d7ed3753561a0...

[Kevin Cernekee, 2016-05-07 23:19:44]

https://codereview.chromium.org/1804293003/diff/510001/make_all.sh
File make_all.sh (right):

https://codereview.chromium.org/1804293003/diff/510001/make_all.sh#newcode32
make_all.sh:32: NACL_ARCH=le32      TOOLCHAIN=pnacl        make ${TARGETS}
Looks like the latest pepper_canary toolchain (r380642) is still missing the
le32 compiler, so this change causes make_all.sh to fail:

pepper_canary/toolchain/linux_pnacl/bin/le32-nacl-clang: No such file or
directory

Also, a nit: the spacing doesn't line up with the other entries.