ports/libvpx/nacl.patch - Issue 1804293003: Add support for new pnacl native toolchain driver

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ports/libvpx/nacl.patch

Issue 1804293003: Add support for new pnacl native toolchain driver (Closed) Base URL: https://chromium.googlesource.com/webports.git@master

Patch Set: Fix according to Brad's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 diff --git a/build/make/Makefile b/build/make/Makefile

	2 --- a/build/make/Makefile

	3 +++ b/build/make/Makefile

	4 @@ -207,6 +207,8 @@ $(BUILD_PFX)%.asm.s: %.asm

	5 # If we're in debug mode, pretend we don't have GNU strip, to fall back to

	6 # the copy implementation

	7 HAVE_GNU_STRIP := $(if $(CONFIG_DEBUG),,$(HAVE_GNU_STRIP))

	8 +# We don't have STRIP in new pnacl driver so fall back to using cp

	9 +HAVE_GNU_STRIP := $(if $(filter $(NACL_ARCH), le32),,$(HAVE_GNU_STRIP))

	10 ifeq ($(HAVE_GNU_STRIP),yes)

	11 # Older binutils strip global symbols not needed for relocation processing

	12 # when given --strip-unneeded. Using nm and awk to identify globals and

	13 diff --git a/build/make/configure.sh b/build/make/configure.sh

	14 --- a/build/make/configure.sh

	15 +++ b/build/make/configure.sh

	16 @@ -428,7 +428,7 @@ NM=${NM}

	17

	18 CFLAGS = ${CFLAGS}

	19 CXXFLAGS = ${CXXFLAGS}

	20 -ARFLAGS = -rus\$(if \$(quiet),c,v)

	21 +ARFLAGS = rus\$(if \$(quiet),c,v)

	22 LDFLAGS = ${LDFLAGS}

	23 ASFLAGS = ${ASFLAGS}

	24 extralibs = ${extralibs}

OLD	NEW