Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: ports/regal/nacl.patch

Issue 1804293003: Add support for new pnacl native toolchain driver (Closed) Base URL: https://chromium.googlesource.com/webports.git@master
Patch Set: Fix according to Brad's comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 diff --git a/.travis.yml b/.travis.yml 1 diff --git a/.travis.yml b/.travis.yml
2 --- a/.travis.yml 2 --- a/.travis.yml
3 +++ b/.travis.yml 3 +++ b/.travis.yml
4 @@ -19,10 +19,14 @@ install: 4 @@ -19,10 +19,16 @@ install:
5 - "if [ \"$SYSTEM\" = linux ]; then sudo apt-get install libxmu-dev libxi-dev; fi" 5 - "if [ \"$SYSTEM\" = linux ]; then sudo apt-get install libxmu-dev libxi-dev; fi"
6 env: 6 env:
7 - SYSTEM=linux 7 - SYSTEM=linux
8 - - SYSTEM=nacl-i686 8 - - SYSTEM=nacl-i686
9 + - SYSTEM=nacl-x86_64 TOOLCHAIN=clang-newlib 9 + - SYSTEM=nacl-x86_64 TOOLCHAIN=clang-newlib
10 + - SYSTEM=nacl-x86_64 TOOLCHAIN=glibc 10 + - SYSTEM=nacl-x86_64 TOOLCHAIN=glibc
11 - SYSTEM=nacl-x86_64 11 - SYSTEM=nacl-x86_64
12 + - SYSTEM=nacl-i686 12 + - SYSTEM=nacl-i686
13 - SYSTEM=nacl-arm 13 - SYSTEM=nacl-arm
14 + - SYSTEM=nacl-pnacl 14 + - SYSTEM=nacl-pnacl
15 + - SYSTEM=nacl-le32
15 - MODE=debug SYSTEM=linux 16 - MODE=debug SYSTEM=linux
16 - - MODE=debug SYSTEM=nacl-i686 17 - - MODE=debug SYSTEM=nacl-i686
17 - MODE=debug SYSTEM=nacl-x86_64 18 - MODE=debug SYSTEM=nacl-x86_64
18 + - MODE=debug SYSTEM=nacl-i686 19 + - MODE=debug SYSTEM=nacl-i686
19 - MODE=debug SYSTEM=nacl-arm 20 - MODE=debug SYSTEM=nacl-arm
20 + - MODE=debug SYSTEM=nacl-pnacl 21 + - MODE=debug SYSTEM=nacl-pnacl
22 + - MODE=debug SYSTEM=nacl-le32
21 diff --git a/Makefile.glu b/Makefile.glu 23 diff --git a/Makefile.glu b/Makefile.glu
22 --- a/Makefile.glu 24 --- a/Makefile.glu
23 +++ b/Makefile.glu 25 +++ b/Makefile.glu
24 @@ -36,7 +36,6 @@ GLU.OBJS := $(GLU.OBJS:.c=.o) $(GLU.OBJS:.cc=.o) 26 @@ -36,7 +36,6 @@ GLU.OBJS := $(GLU.OBJS:.c=.o) $(GLU.OBJS:.cc=.o)
25 GLU.OBJS := $(filter %.o,$(GLU.OBJS)) 27 GLU.OBJS := $(filter %.o,$(GLU.OBJS))
26 GLU.DEPS := $(GLU.OBJS:.o=.d) 28 GLU.DEPS := $(GLU.OBJS:.o=.d)
27 GLU.LIBS := -Llib/$(SYSTEM) -lRegal 29 GLU.LIBS := -Llib/$(SYSTEM) -lRegal
28 -GLU.LIBS += -lstdc++ 30 -GLU.LIBS += -lstdc++
29 GLU.LIBS += -pthread -lm 31 GLU.LIBS += -pthread -lm
30 32
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 +++ b/Makefile.regaltest 151 +++ b/Makefile.regaltest
150 @@ -7,7 +7,7 @@ include build/common.inc 152 @@ -7,7 +7,7 @@ include build/common.inc
151 153
152 # Not supported for Emscripten - Revisit 154 # Not supported for Emscripten - Revisit
153 155
154 -ifeq ($(filter emscripten% nacl-pnacl,$(SYSTEM)),) 156 -ifeq ($(filter emscripten% nacl-pnacl,$(SYSTEM)),)
155 +ifeq ($(filter emscripten%,$(SYSTEM)),) 157 +ifeq ($(filter emscripten%,$(SYSTEM)),)
156 158
157 include build/regaltest.inc 159 include build/regaltest.inc
158 160
159 @@ -58,15 +58,24 @@ tmp/$(SYSTEM)/regaltest/static/%.o: tests/%.cpp 161 @@ -49,7 +49,10 @@ REGALTEST.LIBS := -Llib/$(SYSTEM) $(LDFLAGS.X11) -lm
162 ifeq ($(filter nacl%,$(SYSTEM)),)
163 REGALTEST.LIBS += -ldl
164 else
165 -REGALTEST.LIBS += -lnacl_io -lppapi -lppapi_gles2
166 +ifneq ($(NACL_ARCH),le32)
167 +REGALTEST.LIBS += -lnacl_io -lppapi_gles2
168 +endif
169 +REGALTEST.LIBS += -lppapi
170 endif
171
172 -include $(REGALTEST.DEPS)
173 @@ -58,15 +61,24 @@ tmp/$(SYSTEM)/regaltest/static/%.o: tests/%.cpp
160 @mkdir -p $(dir $@) 174 @mkdir -p $(dir $@)
161 $(LOG_CXX)$(CCACHE) $(CXX) $(REGAL.CFLAGS) $(REGALTEST.CFLAGS) $(CFLAGS) $(CFLAGS.SO) -o $@ -c $< 175 $(LOG_CXX)$(CCACHE) $(CXX) $(REGAL.CFLAGS) $(REGALTEST.CFLAGS) $(CFLAGS) $(CFLAGS.SO) -o $@ -c $<
162 176
163 +ifeq ($(NACL_ARCH),pnacl) 177 +ifeq ($(NACL_ARCH),pnacl)
164 +LINK_OUTPUT_EXT=.bc 178 +LINK_OUTPUT_EXT=.bc
165 +else 179 +else
166 +LINK_OUTPUT_EXT=$(BIN_EXTENSION) 180 +LINK_OUTPUT_EXT=$(BIN_EXTENSION)
167 +endif 181 +endif
168 + 182 +
169 bin/$(SYSTEM)/regaltest$(BIN_EXTENSION): $(REGALTEST.OBJS) lib/$(SYSTEM)/$(GTES T.STATIC) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PCRE.STATIC) $(REGAL.SHA RED.DEPEND) 183 bin/$(SYSTEM)/regaltest$(BIN_EXTENSION): $(REGALTEST.OBJS) lib/$(SYSTEM)/$(GTES T.STATIC) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PCRE.STATIC) $(REGAL.SHA RED.DEPEND)
170 @mkdir -p $(dir $@) 184 @mkdir -p $(dir $@)
171 ifdef APITRACE.STATIC 185 ifdef APITRACE.STATIC
172 $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $@ $(REGALTEST.OBJS) $(LDFL AGS.STARTGROUP) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(APITRACE.STATIC) $ (LDFLAGS.ENDGROUP) $(REGAL.SHARED.DEPEND) $(REGAL.LIBS) $(REGALTEST.LIBS) lib/$( SYSTEM)/$(PCRE.STATIC) lib/$(SYSTEM)/$(GTEST.STATIC) $(REGAL.LDFLAGS) 186 $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $@ $(REGALTEST.OBJS) $(LDFL AGS.STARTGROUP) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(APITRACE.STATIC) $ (LDFLAGS.ENDGROUP) $(REGAL.SHARED.DEPEND) $(REGAL.LIBS) $(REGALTEST.LIBS) lib/$( SYSTEM)/$(PCRE.STATIC) lib/$(SYSTEM)/$(GTEST.STATIC) $(REGAL.LDFLAGS)
173 else 187 else
174 - $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $@ $(REGALTEST.OBJS) lib/$( SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PCRE.STATIC) $(REGAL.SHARED.DEPEND) $(RE GAL.LIBS) $(REGALTEST.LIBS) lib/$(SYSTEM)/$(GTEST.STATIC) $(REGAL.LDFLAGS) 188 - $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $@ $(REGALTEST.OBJS) lib/$( SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PCRE.STATIC) $(REGAL.SHARED.DEPEND) $(RE GAL.LIBS) $(REGALTEST.LIBS) lib/$(SYSTEM)/$(GTEST.STATIC) $(REGAL.LDFLAGS)
175 + $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $(@:$(BIN_EXTENSION)=$(LINK _OUTPUT_EXT)) $(REGALTEST.OBJS) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PC RE.STATIC) $(REGAL.SHARED.DEPEND) $(REGAL.LIBS) $(REGALTEST.LIBS) lib/$(SYSTEM)/ $(GTEST.STATIC) $(REGAL.LDFLAGS) 189 + $(LOG_LD)$(CCACHE) $(LD) $(LDFLAGS.EXTRA) -o $(@:$(BIN_EXTENSION)=$(LINK _OUTPUT_EXT)) $(REGALTEST.OBJS) lib/$(SYSTEM)/$(REGAL.STATIC) lib/$(SYSTEM)/$(PC RE.STATIC) $(REGAL.SHARED.DEPEND) $(REGAL.LIBS) $(REGALTEST.LIBS) lib/$(SYSTEM)/ $(GTEST.STATIC) $(REGAL.LDFLAGS)
176 endif 190 endif
177 ifneq ($(STRIP),) 191 ifneq ($(STRIP),)
178 - $(LOG_STRIP)$(STRIP) -x $@ 192 - $(LOG_STRIP)$(STRIP) -x $@
179 + $(LOG_STRIP)$(STRIP) $(@:$(BIN_EXTENSION)=$(LINK_OUTPUT_EXT)) 193 + $(LOG_STRIP)$(STRIP) $(@:$(BIN_EXTENSION)=$(LINK_OUTPUT_EXT))
180 +endif 194 +endif
181 +ifeq ($(NACL_ARCH),pnacl) 195 +ifeq ($(NACL_ARCH),pnacl)
182 + $(LOG_FINALIZE)$(FINALIZE) -o $@ $(@:$(BIN_EXTENSION)=$(LINK_OUTPUT_EXT) ) 196 + $(LOG_FINALIZE)$(FINALIZE) -o $@ $(@:$(BIN_EXTENSION)=$(LINK_OUTPUT_EXT) )
183 endif 197 endif
184 198
185 ifneq ($(NACL_ARCH),arm) 199 ifneq ($(NACL_ARCH),arm)
186 @@ -75,7 +84,10 @@ test: bin/$(SYSTEM)/regaltest$(BIN_EXTENSION) 200 @@ -75,7 +84,12 @@ test: bin/$(SYSTEM)/regaltest$(BIN_EXTENSION)
187 ifeq ($(filter nacl%,$(SYSTEM)),) 201 ifeq ($(filter nacl%,$(SYSTEM)),)
188 $^ 202 $^
189 else 203 else
190 - "$(NACL_SDK_ROOT)/tools/sel_ldr.py" $^ 204 - "$(NACL_SDK_ROOT)/tools/sel_ldr.py" $^
191 +ifeq ($(NACL_ARCH),pnacl) 205 +ifeq ($(NACL_ARCH),pnacl)
192 + $(LOG_FINALIZE)$(TRANSLATE) -arch x86-64 -o $(^:.pexe=.nexe) $^ 206 + $(LOG_FINALIZE)$(TRANSLATE) -arch x86-64 -o $(^:.pexe=.nexe) $^
207 +else ifeq ($(NACL_ARCH),le32)
208 + $(TRANSLATE) -arch x86-64 -o $(^:.pexe=.nexe) $^
193 +endif 209 +endif
194 + "$(NACL_SDK_ROOT)/tools/sel_ldr.py" $(^:.pexe=.nexe) 210 + "$(NACL_SDK_ROOT)/tools/sel_ldr.py" $(^:.pexe=.nexe)
195 endif 211 endif
196 endif 212 endif
197 213
198 diff --git a/Makefile.regalw b/Makefile.regalw 214 diff --git a/Makefile.regalw b/Makefile.regalw
199 --- a/Makefile.regalw 215 --- a/Makefile.regalw
200 +++ b/Makefile.regalw 216 +++ b/Makefile.regalw
201 @@ -12,18 +12,23 @@ include build/regal.inc 217 @@ -12,18 +12,23 @@ include build/regal.inc
202 # 218 #
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
383 CC := $(NACL_TOOLCHAIN)/bin/i686-nacl-gcc 399 CC := $(NACL_TOOLCHAIN)/bin/i686-nacl-gcc
384 CXX := $(NACL_TOOLCHAIN)/bin/i686-nacl-g++ 400 CXX := $(NACL_TOOLCHAIN)/bin/i686-nacl-g++
385 LD := $(NACL_TOOLCHAIN)/bin/i686-nacl-g++ 401 LD := $(NACL_TOOLCHAIN)/bin/i686-nacl-g++
386 AR := $(NACL_TOOLCHAIN)/bin/i686-nacl-ar 402 AR := $(NACL_TOOLCHAIN)/bin/i686-nacl-ar
387 OBJDUMP:= $(NACL_TOOLCHAIN)/bin/i686-nacl-objdump 403 OBJDUMP:= $(NACL_TOOLCHAIN)/bin/i686-nacl-objdump
388 +endif 404 +endif
389 + 405 +
390 RANLIB := 406 RANLIB :=
391 STRIP ?= 407 STRIP ?=
392 408
409 diff --git a/config/Makefile.nacl-le32 b/config/Makefile.nacl-le32
410 new file mode 100644
411 --- /dev/null
412 +++ b/config/Makefile.nacl-le32
413 @@ -0,0 +1,25 @@
414 +NACL_ARCH := le32
415 +TOOLCHAIN := pnacl
416 +
417 +include config/nacl.inc
418 +
419 +NACL_TOOLCHAIN := $(NACL_SDK_ROOT)/toolchain/$(NACL_OS)_pnacl
420 +
421 +CC := $(NACL_TOOLCHAIN)/bin/le32-nacl-clang
422 +CXX := $(NACL_TOOLCHAIN)/bin/le32-nacl-clang++
423 +LD := $(NACL_TOOLCHAIN)/bin/le32-nacl-clang++
424 +TRANSLATE := $(NACL_TOOLCHAIN)/bin/pnacl-translate
425 +AR := $(NACL_TOOLCHAIN)/bin/le32-nacl-ar
426 +RANLIB := $(NACL_TOOLCHAIN)/bin/le32-nacl-ranlib
427 +STRIP ?=
428 +
429 +BIN_EXTENSION = .pexe
430 +LIBDIR =
431 +CFLAGS.EXTRA += -Wno-tautological-undefined-compare -Wno-unused-function
432 +LDFLAGS.EXTRA +=
433 +LDFLAGS.GL =
434 +LDFLAGS.GLU = -lRegalGLU
435 +LDFLAGS.GLUT = -lRegalGLUT
436 +LDFLAGS.STATIC =
437 +BIN.SUFFIX =
438 +LIB.STATIC = lib$(NAME).a
393 diff --git a/config/Makefile.nacl-pnacl b/config/Makefile.nacl-pnacl 439 diff --git a/config/Makefile.nacl-pnacl b/config/Makefile.nacl-pnacl
394 --- a/config/Makefile.nacl-pnacl 440 --- a/config/Makefile.nacl-pnacl
395 +++ b/config/Makefile.nacl-pnacl 441 +++ b/config/Makefile.nacl-pnacl
396 @@ -1,29 +1,26 @@ 442 @@ -1,29 +1,26 @@
397 NACL_ARCH := pnacl 443 NACL_ARCH := pnacl
398 +TOOLCHAIN := pnacl 444 +TOOLCHAIN := pnacl
399 445
400 include config/nacl.inc 446 include config/nacl.inc
401 447
402 NACL_TOOLCHAIN := $(NACL_SDK_ROOT)/toolchain/$(NACL_OS)_pnacl 448 NACL_TOOLCHAIN := $(NACL_SDK_ROOT)/toolchain/$(NACL_OS)_pnacl
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
521 567
522 CFLAGS.EXTRA += -I$(NACL_SDK_ROOT)/include -MMD 568 CFLAGS.EXTRA += -I$(NACL_SDK_ROOT)/include -MMD
523 WARN = -Wall -Wno-unused-parameter -Wno-char-subscripts -Wno-strict-aliasing 569 WARN = -Wall -Wno-unused-parameter -Wno-char-subscripts -Wno-strict-aliasing
524 -# WARN += -Werror 570 -# WARN += -Werror
525 +#WARN += -Werror 571 +#WARN += -Werror
526 CFLAGS.DEBUG = -g 572 CFLAGS.DEBUG = -g
527 CFLAGS.RELEASE = -O2 573 CFLAGS.RELEASE = -O2
528 diff --git a/nacl-regal.sh b/nacl-regal.sh 574 diff --git a/nacl-regal.sh b/nacl-regal.sh
529 --- a/nacl-regal.sh 575 --- a/nacl-regal.sh
530 +++ b/nacl-regal.sh 576 +++ b/nacl-regal.sh
531 @@ -10,22 +10,24 @@ 577 @@ -10,22 +10,28 @@
532 # - Pepper 25 is needed for the ARM build. 578 # - Pepper 25 is needed for the ARM build.
533 # - Makefile needs to be specified for branches that have GNUmakefiles 579 # - Makefile needs to be specified for branches that have GNUmakefiles
534 # - MODE=debug for debug-mode build 580 # - MODE=debug for debug-mode build
535 -# - NACL_LIBC=glibc on the command-line for glibc rather than newlib 581 -# - NACL_LIBC=glibc on the command-line for glibc rather than newlib
536 +# - TOOLCHAIN=glibc or clang-newlib to use and alternative to the default 582 +# - TOOLCHAIN=glibc or clang-newlib to use and alternative to the default
537 +# newlib toolchain. 583 +# newlib toolchain.
538 # - CCACHE=ccache is supported (and recommended) 584 # - CCACHE=ccache is supported (and recommended)
539 585
540 set -e 586 set -e
541 587
(...skipping 10 matching lines...) Expand all
552 - echo "Building ARM" 598 - echo "Building ARM"
553 - make -f Makefile SYSTEM=nacl-arm $* 599 - make -f Makefile SYSTEM=nacl-arm $*
554 -fi 600 -fi
555 +echo "Building ARM" 601 +echo "Building ARM"
556 +make -f Makefile SYSTEM=nacl-arm $* 602 +make -f Makefile SYSTEM=nacl-arm $*
557 +make -f Makefile SYSTEM=nacl-arm $* test 603 +make -f Makefile SYSTEM=nacl-arm $* test
558 604
559 echo "Building pnacl" 605 echo "Building pnacl"
560 make -f Makefile SYSTEM=nacl-pnacl $* 606 make -f Makefile SYSTEM=nacl-pnacl $*
561 +make -f Makefile SYSTEM=nacl-pnacl $* test 607 +make -f Makefile SYSTEM=nacl-pnacl $* test
608 +
609 +echo "Building pnacl"
610 +make -f Makefile SYSTEM=nacl-le32 $*
611 +make -f Makefile SYSTEM=nacl-le32 $* test
562 diff --git a/src/apitrace/common/os_posix.cpp b/src/apitrace/common/os_posix.cpp 612 diff --git a/src/apitrace/common/os_posix.cpp b/src/apitrace/common/os_posix.cpp
563 --- a/src/apitrace/common/os_posix.cpp 613 --- a/src/apitrace/common/os_posix.cpp
564 +++ b/src/apitrace/common/os_posix.cpp 614 +++ b/src/apitrace/common/os_posix.cpp
565 @@ -123,7 +123,7 @@ getCurrentDir(void) 615 @@ -123,7 +123,7 @@ getCurrentDir(void)
566 size_t size = PATH_MAX; 616 size_t size = PATH_MAX;
567 char *buf = path.buf(size); 617 char *buf = path.buf(size);
568 618
569 - getcwd(buf, size); 619 - getcwd(buf, size);
570 + buf = getcwd(buf, size); 620 + buf = getcwd(buf, size);
571 buf[size - 1] = 0; 621 buf[size - 1] = 0;
(...skipping 28 matching lines...) Expand all
600 +++ b/src/regal/RegalUtil.h 650 +++ b/src/regal/RegalUtil.h
601 @@ -56,7 +56,7 @@ 651 @@ -56,7 +56,7 @@
602 #endif 652 #endif
603 653
604 #ifndef REGAL_UNUSED 654 #ifndef REGAL_UNUSED
605 -#if defined(__GNUC__) && !defined(__clang__) 655 -#if defined(__GNUC__) && !defined(__clang__)
606 +#if defined(__GNUC__) 656 +#if defined(__GNUC__)
607 #define REGAL_UNUSED __attribute__((unused)) 657 #define REGAL_UNUSED __attribute__((unused))
608 #else 658 #else
609 #define REGAL_UNUSED 659 #define REGAL_UNUSED
OLDNEW
« make_all.sh ('K') | « ports/quakespasm/nacl.patch ('k') | ports/scummvm/build.sh » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698