DevTools: encapsulate presentation model in timeline view.

DevTools: encapsulate presentation model in timeline view.

R=caseq@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168396

[caseq, 2014-03-04 15:47:49]

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelinePanel.js (right):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePanel.js:77:
this._model.addFilter(this._windowFilter);
indent

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePanel.js:1072: return innerTraverse.call(this,
record);
Use farAllRecords?

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineView.js (left):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:459:
this._presentationModel.invalidateFilteredRecords();
Why is this gone?

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineView.js (right):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:47: this._presentationModel = new
WebInspector.TimelinePresentationModel(model, delegate);
drop delegagte

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:714: if
((!record.hasPresentationChildren() || record.collapsed()) &&
record.presentationParent() !== this._presentationModel.rootRecord()) {
This seems to be different from the old logic.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:730: if
(record.hasPresentationChildren() && record.collapsed()) {
ditto

[pfeldman, 2014-03-04 16:01:28]

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelinePanel.js (right):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePanel.js:77:
this._model.addFilter(this._windowFilter);
On 2014/03/04 15:47:49, caseq wrote:
> indent

Done.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePanel.js:1072: return innerTraverse.call(this,
record);
On 2014/03/04 15:47:49, caseq wrote:
> Use farAllRecords?

Done.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineView.js (left):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:459:
this._presentationModel.invalidateFilteredRecords();
On 2014/03/04 15:47:49, caseq wrote:
> Why is this gone?

Done.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/TimelineView.js (right):

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:47: this._presentationModel = new
WebInspector.TimelinePresentationModel(model, delegate);
On 2014/03/04 15:47:49, caseq wrote:
> drop delegagte

Done.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:714: if
((!record.hasPresentationChildren() || record.collapsed()) &&
record.presentationParent() !== this._presentationModel.rootRecord()) {
On 2014/03/04 15:47:49, caseq wrote:
> This seems to be different from the old logic.

Done.

https://codereview.chromium.org/180273023/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/TimelineView.js:730: if
(record.hasPresentationChildren() && record.collapsed()) {
On 2014/03/04 15:47:49, caseq wrote:
> ditto

Done.

[caseq, 2014-03-04 16:38:03]

lgtm

https://codereview.chromium.org/180273023/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/TimelinePanel.js (right):

https://codereview.chromium.org/180273023/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePanel.js:1068:
WebInspector.TimelineModel.forAllRecords([record], processRecord.bind(this));
Can we have forAllRecords() return some indication that we exited due to
callback? This would make things a bit simpler here.

https://codereview.chromium.org/180273023/diff/40001/Source/devtools/front_en...
File Source/devtools/front_end/TimelinePresentationModel.js (right):

https://codereview.chromium.org/180273023/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePresentationModel.js:234: var recordsInWindow
= [];
indent

https://codereview.chromium.org/180273023/diff/40001/Source/devtools/front_en...
Source/devtools/front_end/TimelinePresentationModel.js:237: var revealedDepth =
0;
ditto

[pfeldman, 2014-03-04 17:39:17]

Committed patchset #5 manually as r168396 (presubmit successful).