Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7587)

Unified Diff: Source/devtools/front_end/TimelineFlameChart.js

Issue 180273023: DevTools: encapsulate presentation model in timeline view. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelineFrameModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/TimelineFlameChart.js b/Source/devtools/front_end/TimelineFlameChart.js
index ac9a638ce47295edb096d5d23e05d7a7f72633f9..da9dc56e6031016203f03db1bdf42c2e3131faaa 100644
--- a/Source/devtools/front_end/TimelineFlameChart.js
+++ b/Source/devtools/front_end/TimelineFlameChart.js
@@ -200,7 +200,7 @@ WebInspector.TimelineFlameChartDataProvider.prototype = {
var index = this._entryTitles.length;
this._entryTitles[index] = record.type;
timelineData.entryOffsets[index] = record.startTime - startTime;
- timelineData.entryLevels[index] = depth - 1;
+ timelineData.entryLevels[index] = depth;
timelineData.entryTotalTimes[index] = endTime - record.startTime;
this._entryColors[index] = this._colorGenerator.colorForID(WebInspector.TimelineUIUtils.categoryForRecord(record).name);
this._maxStackDepth = Math.max(this._maxStackDepth, depth + 1);
@@ -274,8 +274,13 @@ WebInspector.TimelineFlameChart.prototype = {
this._delegate.requestWindowTimes(windowStartTime, windowEndTime);
},
- refreshRecords: function()
+ /**
+ * @param {?RegExp} textFilter
+ */
+ refreshRecords: function(textFilter)
{
+ this._dataProvider.reset();
+ this._mainView._scheduleUpdate();
},
reset: function()
@@ -351,4 +356,4 @@ WebInspector.TimelineFlameChart.prototype = {
},
__proto__: WebInspector.View.prototype
-}
+}
« no previous file with comments | « Source/devtools/front_end/MemoryStatistics.js ('k') | Source/devtools/front_end/TimelineFrameModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698