Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: Source/devtools/front_end/TimelineFrameModel.js

Issue 180273023: DevTools: encapsulate presentation model in timeline view. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: For landing Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/TimelineFlameChart.js ('k') | Source/devtools/front_end/TimelineModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/TimelineFrameModel.js
diff --git a/Source/devtools/front_end/TimelineFrameModel.js b/Source/devtools/front_end/TimelineFrameModel.js
index 87ac921d64e7e2413105554ae161a60c57bcf59a..35f80aefc9fe11dca466fab91a585c49fa08cad5 100644
--- a/Source/devtools/front_end/TimelineFrameModel.js
+++ b/Source/devtools/front_end/TimelineFrameModel.js
@@ -202,7 +202,7 @@ WebInspector.TimelineFrameModel.prototype = {
if (this._lastFrame)
this._flushFrame(this._lastFrame, record);
- this._lastFrame = new WebInspector.TimelineFrame(this, record);
+ this._lastFrame = new WebInspector.TimelineFrame(record);
},
/**
@@ -212,7 +212,7 @@ WebInspector.TimelineFrameModel.prototype = {
{
if (this._lastFrame)
this._flushFrame(this._lastFrame, record);
- this._lastFrame = new WebInspector.TimelineFrame(this, record);
+ this._lastFrame = new WebInspector.TimelineFrame(record);
},
/**
@@ -279,13 +279,12 @@ WebInspector.FrameStatistics = function(frames)
/**
* @constructor
- * @param {!WebInspector.TimelineFrameModel} model
* @param {!Object} record
*/
-WebInspector.TimelineFrame = function(model, record)
+WebInspector.TimelineFrame = function(record)
{
this.startTime = record.startTime;
- this.startTimeOffset = model._model.recordOffsetInMillis(record);
+ this.startTimeOffset = record.startTimeOffset;
this.endTime = this.startTime;
this.duration = 0;
this.timeByCategory = {};
« no previous file with comments | « Source/devtools/front_end/TimelineFlameChart.js ('k') | Source/devtools/front_end/TimelineModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698