Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: pkg/polymer/lib/src/declaration.dart

Issue 180273004: Fixes in smoke, which in turn should fix todomvc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/src/declaration.dart
diff --git a/pkg/polymer/lib/src/declaration.dart b/pkg/polymer/lib/src/declaration.dart
index d2b50a7619255abfdb5f1ba6244b605e816b3913..de01b8ea1bf52eda9d3bd8a4aeb3e48ce9ab55ea 100644
--- a/pkg/polymer/lib/src/declaration.dart
+++ b/pkg/polymer/lib/src/declaration.dart
@@ -455,7 +455,8 @@ class PolymerDeclaration extends HtmlElement {
*/
void inferObservers() {
var options = const smoke.QueryOptions(includeFields: false,
- includeProperties: false, includeMethods: true, includeInherited: true);
+ includeProperties: false, includeMethods: true, includeInherited: true,
+ includeUpTo: HtmlElement);
Siggi Cherem (dart-lang) 2014/02/25 23:23:23 this API change was not needed to fix things, but
Jennifer Messerly 2014/02/25 23:50:09 Very nice!
for (var decl in smoke.query(_type, options)) {
String name = smoke.symbolToName(decl.name);
if (name.endsWith(_OBSERVE_SUFFIX) && name != 'attributeChanged') {
@@ -475,7 +476,7 @@ class PolymerDeclaration extends HtmlElement {
void explodeObservers() {
var options = const smoke.QueryOptions(includeFields: false,
includeProperties: false, includeMethods: true, includeInherited: true,
- withAnnotations: const [ObserveProperty]);
+ includeUpTo: HtmlElement, withAnnotations: const [ObserveProperty]);
for (var decl in smoke.query(_type, options)) {
for (var meta in decl.annotations) {
if (meta is! ObserveProperty) continue;
@@ -535,7 +536,7 @@ PolymerDeclaration _getDeclaration(String name) => _declarations[name];
Map<PropertyPath, smoke.Declaration> _getPublishedProperties(
Type type, Map<PropertyPath, smoke.Declaration> props) {
var options = const smoke.QueryOptions(includeInherited: true,
- withAnnotations: const [PublishedProperty]);
+ includeUpTo: HtmlElement, withAnnotations: const [PublishedProperty]);
for (var decl in smoke.query(type, options)) {
if (decl.isFinal) continue;
if (props == null) props = {};

Powered by Google App Engine
This is Rietveld 408576698