Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Unified Diff: pkg/polymer/lib/polymer.dart

Issue 180273004: Fixes in smoke, which in turn should fix todomvc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/lib/polymer.dart
diff --git a/pkg/polymer/lib/polymer.dart b/pkg/polymer/lib/polymer.dart
index d00fee246bf52d58dc397d1fa236674c5df5a48b..6fdfc8103894fa3f9bff22db170ceda423d83069 100644
--- a/pkg/polymer/lib/polymer.dart
+++ b/pkg/polymer/lib/polymer.dart
@@ -46,6 +46,7 @@ import 'dart:js' as js;
@MirrorsUsed(metaTargets:
const [Reflectable, ObservableProperty, CustomTag, _InitMethodAnnotation],
+ targets: const [PublishedProperty],
Siggi Cherem (dart-lang) 2014/02/25 23:23:23 needed to check that this extends from ObservableP
Jennifer Messerly 2014/02/25 23:50:09 yeah, seems fine, but shouldn't it be a metatarget
Siggi Cherem (dart-lang) 2014/02/26 00:09:50 good point. However, I had to include it in both.
override: const ['smoke.mirrors', 'polymer'])
import 'dart:mirrors';

Powered by Google App Engine
This is Rietveld 408576698