Fixes in smoke, which in turn should fix todomvc.

pkg/polymer/lib/src/declaration.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /**
  * **Warning**: this class is experiental and subject to change.
  *
  * The implementation for the `polymer-element` element.
@@ skipping 437 matching lines @@
         ..text = cssText
         ..attributes[_STYLE_SCOPE_ATTRIBUTE] = '$name-$scopeDescriptor';
   }
 
   /**
    * Fetch a list of all *Changed methods so we can observe the associated
    * properties.
    */
   void inferObservers() {
     var options = const smoke.QueryOptions(includeFields: false,
-        includeProperties: false, includeMethods: true, includeInherited: true);
+        includeProperties: false, includeMethods: true, includeInherited: true,
+        includeUpTo: HtmlElement);

[Siggi Cherem (dart-lang), 2014/02/25 23:23:23]

this API change was not needed to fix things, but as I was debugging it was
useful to implement it. This was anyways how it used to be.

Later on we could add other filters. For example, stop whenever the base class
belongs to the core-libraries (this would help in the case of the observable
code)

[Jennifer Messerly, 2014/02/25 23:50:09]

Very nice!

     for (var decl in smoke.query(_type, options)) {
       String name = smoke.symbolToName(decl.name);
       if (name.endsWith(_OBSERVE_SUFFIX) && name != 'attributeChanged') {
         // TODO(jmesserly): now that we have a better system, should we
         // deprecate *Changed methods?
         if (_observe == null) _observe = new HashMap();
         name = name.substring(0, name.length - 7);
         _observe[new PropertyPath(name)] = [decl.name];
       }
     }
   }
 
   /**
    * Fetch a list of all methods annotated with [ObserveProperty] so we can
    * observe the associated properties.
    */
   void explodeObservers() {
     var options = const smoke.QueryOptions(includeFields: false,
         includeProperties: false, includeMethods: true, includeInherited: true,
-        withAnnotations: const [ObserveProperty]);
+        includeUpTo: HtmlElement, withAnnotations: const [ObserveProperty]);
     for (var decl in smoke.query(_type, options)) {
       for (var meta in decl.annotations) {
         if (meta is! ObserveProperty) continue;
         if (_observe == null) _observe = new HashMap();
         for (String name in meta.names) {
           _observe.putIfAbsent(new PropertyPath(name), () => []).add(decl.name);
         }
       }
     }
   }
@@ skipping 39 matching lines @@
 
 /// track document.register'ed tag names and their declarations
 final Map _declarations = new Map<String, PolymerDeclaration>();
 
 bool _isRegistered(String name) => _declarations.containsKey(name);
 PolymerDeclaration _getDeclaration(String name) => _declarations[name];
 
 Map<PropertyPath, smoke.Declaration> _getPublishedProperties(
     Type type, Map<PropertyPath, smoke.Declaration> props) {
   var options = const smoke.QueryOptions(includeInherited: true,
-      withAnnotations: const [PublishedProperty]);
+      includeUpTo: HtmlElement, withAnnotations: const [PublishedProperty]);
   for (var decl in smoke.query(type, options)) {
     if (decl.isFinal) continue;
     if (props == null) props = {};
     props[new PropertyPath([decl.name])] = decl;
   }
   return props;
 }
 
 /** Attribute prefix used for declarative event handlers. */
 const _EVENT_PREFIX = 'on-';
@@ skipping 95 matching lines @@
 
 // Dart note: we need this function because we have additional renames JS does
 // not have. The JS renames are simply case differences, whereas we have ones
 // like doubleclick -> dblclick and stripping the webkit prefix.
 String _eventNameFromType(String eventType) {
   final result = _reverseEventTranslations[eventType];
   return result != null ? result : eventType;
 }
 
 final _ATTRIBUTES_REGEX = new RegExp(r'\s|,');