Replace ConstNodeRange with a const_cast

Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/931d445decae8359a79bebbcff6a3a3d43343b85
Cr-Commit-Position: refs/heads/master@{#383882}

[ncarter (slow), 2016-03-14 23:11:14]

Description was changed from

==========
Replace ConstNodeRange with a const_cast

BUG=
==========

to

==========
Replace ConstNodeRange with a const_cast

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-03-16 21:48:08]

Description was changed from

==========
Replace ConstNodeRange with a const_cast

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[ncarter (slow), 2016-03-16 21:53:09]

nick@chromium.org changed reviewers:
+ clamy@chromium.org, nasko@chromium.org

[ncarter (slow), 2016-03-16 21:53:10]

This eliminates a duplicate implementation of the traversal logic.

I initially tried implementing the non-const iterator in terms of the const
iterator, but it only saved about 20 lines of code.

When I realized this was only needed for IsLoading, I thought a const_cast was a
better solution. const correctness is an explicit non-goal for content/public
classes.

[clamy, 2016-03-17 10:51:47]

Considering that IsLoading was only made const because it is used in
WebContentsImpl::IsLoading which is const, can we just unconst
WebContentsImpl::IsLoading and even not have to do a const cast? The
content/public API should not have const method anyway (I did not change that in
my CL because it was already big enough).

[ncarter (slow), 2016-03-18 21:14:31]

On 2016/03/17 10:51:47, clamy wrote:
> Considering that IsLoading was only made const because it is used in
> WebContentsImpl::IsLoading which is const, can we just unconst
> WebContentsImpl::IsLoading and even not have to do a const cast? The
> content/public API should not have const method anyway (I did not change that
in
> my CL because it was already big enough).

IsLoading has a bunch of callers, and I'm not sure it's actually worth anybody's
time to unconst all of WebContents, even though it's against the content api
rules. I am wondering if we should change the rules.

That's why I like const_cast as a compromise here: it lets us keep up the facade
of const correctness, without forcing us to overcomplicate our implementation.

[clamy, 2016-03-23 12:08:36]

Acknowledged. Lgtm.

[nasko, 2016-03-23 16:26:24]

Code removal is best CL! LGTM

[ncarter (slow), 2016-03-24 16:58:23]

The CQ bit was checked by nick@chromium.org

[commit-bot: I haz the power, 2016-03-24 16:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802163002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802163002/1

[commit-bot: I haz the power, 2016-03-24 17:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 17:01:07]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ncarter (slow), 2016-03-29 22:48:45]

The CQ bit was checked by nick@chromium.org

[ncarter (slow), 2016-03-29 22:48:46]

The patchset sent to the CQ was uploaded after l-g-t-m from clamy@chromium.org,
nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/1802163002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-03-29 22:49:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1802163002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1802163002/20001

[commit-bot: I haz the power, 2016-03-30 00:59:14]

Description was changed from

==========
Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[commit-bot: I haz the power, 2016-03-30 00:59:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-30 01:00:23]

Description was changed from

==========
Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Replace ConstNodeRange with a const_cast

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/931d445decae8359a79bebbcff6a3a3d43343b85
Cr-Commit-Position: refs/heads/master@{#383882}
==========

[commit-bot: I haz the power, 2016-03-30 01:00:24]

Patchset 2 (id:??) landed as
https://crrev.com/931d445decae8359a79bebbcff6a3a3d43343b85
Cr-Commit-Position: refs/heads/master@{#383882}