Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: content/browser/frame_host/frame_tree.h

Issue 1802163002: Replace ConstNodeRange with a const_cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/frame_tree.h
diff --git a/content/browser/frame_host/frame_tree.h b/content/browser/frame_host/frame_tree.h
index 9b1b29db2d5a2d04f7b535c293bf3fe7edba1dd5..840228d412d4c4128a25a4b8742f93bc78c5f961 100644
--- a/content/browser/frame_host/frame_tree.h
+++ b/content/browser/frame_host/frame_tree.h
@@ -42,7 +42,6 @@ class RenderWidgetHostDelegate;
class CONTENT_EXPORT FrameTree {
public:
class NodeRange;
- class ConstNodeRange;
class CONTENT_EXPORT NodeIterator
: public std::iterator<std::forward_iterator_tag, FrameTreeNode> {
@@ -81,42 +80,6 @@ class CONTENT_EXPORT FrameTree {
FrameTreeNode* const node_to_skip_;
};
- class CONTENT_EXPORT ConstNodeIterator {
- public:
- ConstNodeIterator(const ConstNodeIterator& other);
- ~ConstNodeIterator();
-
- ConstNodeIterator& operator++();
-
- bool operator==(const ConstNodeIterator& rhs) const;
- bool operator!=(const ConstNodeIterator& rhs) const {
- return !(*this == rhs);
- }
-
- const FrameTreeNode* operator*() { return current_node_; }
-
- private:
- friend class ConstNodeRange;
-
- ConstNodeIterator(const FrameTreeNode* starting_node);
-
- const FrameTreeNode* current_node_;
- std::queue<const FrameTreeNode*> queue_;
- };
-
- class CONTENT_EXPORT ConstNodeRange {
- public:
- ConstNodeIterator begin();
- ConstNodeIterator end();
-
- private:
- friend class FrameTree;
-
- ConstNodeRange(const FrameTreeNode* root);
-
- const FrameTreeNode* const root_;
- };
-
// Each FrameTreeNode will default to using the given |navigator| for
// navigation tasks in the frame.
// A set of delegates are remembered here so that we can create
@@ -153,10 +116,6 @@ class CONTENT_EXPORT FrameTree {
// frame tree, starting from |subtree_root|.
NodeRange SubtreeNodes(FrameTreeNode* subtree_root);
- // Returns a range to iterate over all FrameTreeNodes in the frame tree in
- // breadth-first traversal order. All FrameTreeNodes returned will be const.
- ConstNodeRange ConstNodes() const;
-
// Adds a new child frame to the frame tree. |process_id| is required to
// disambiguate |new_routing_id|, and it must match the process of the
// |parent| node. Otherwise no child is added and this method returns false.
« no previous file with comments | « no previous file | content/browser/frame_host/frame_tree.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698