Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: content/browser/frame_host/frame_tree.cc

Issue 1802163002: Replace ConstNodeRange with a const_cast (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/frame_tree.h" 5 #include "content/browser/frame_host/frame_tree.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <queue> 9 #include <queue>
10 #include <utility> 10 #include <utility>
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 } 76 }
77 77
78 FrameTree::NodeIterator FrameTree::NodeRange::end() { 78 FrameTree::NodeIterator FrameTree::NodeRange::end() {
79 return NodeIterator(nullptr, nullptr); 79 return NodeIterator(nullptr, nullptr);
80 } 80 }
81 81
82 FrameTree::NodeRange::NodeRange(FrameTreeNode* root, 82 FrameTree::NodeRange::NodeRange(FrameTreeNode* root,
83 FrameTreeNode* node_to_skip) 83 FrameTreeNode* node_to_skip)
84 : root_(root), node_to_skip_(node_to_skip) {} 84 : root_(root), node_to_skip_(node_to_skip) {}
85 85
86 FrameTree::ConstNodeIterator::ConstNodeIterator(
87 const ConstNodeIterator& other) = default;
88
89 FrameTree::ConstNodeIterator::~ConstNodeIterator() {}
90
91 FrameTree::ConstNodeIterator& FrameTree::ConstNodeIterator::operator++() {
92 for (size_t i = 0; i < current_node_->child_count(); ++i) {
93 const FrameTreeNode* child = current_node_->child_at(i);
94 queue_.push(child);
95 }
96
97 if (!queue_.empty()) {
98 current_node_ = queue_.front();
99 queue_.pop();
100 } else {
101 current_node_ = nullptr;
102 }
103
104 return *this;
105 }
106
107 bool FrameTree::ConstNodeIterator::operator==(
108 const ConstNodeIterator& rhs) const {
109 return current_node_ == rhs.current_node_;
110 }
111
112 FrameTree::ConstNodeIterator::ConstNodeIterator(
113 const FrameTreeNode* starting_node)
114 : current_node_(starting_node) {}
115
116 FrameTree::ConstNodeIterator FrameTree::ConstNodeRange::begin() {
117 return ConstNodeIterator(root_);
118 }
119
120 FrameTree::ConstNodeIterator FrameTree::ConstNodeRange::end() {
121 return ConstNodeIterator(nullptr);
122 }
123
124 FrameTree::ConstNodeRange::ConstNodeRange(const FrameTreeNode* root)
125 : root_(root) {}
126
127 FrameTree::FrameTree(Navigator* navigator, 86 FrameTree::FrameTree(Navigator* navigator,
128 RenderFrameHostDelegate* render_frame_delegate, 87 RenderFrameHostDelegate* render_frame_delegate,
129 RenderViewHostDelegate* render_view_delegate, 88 RenderViewHostDelegate* render_view_delegate,
130 RenderWidgetHostDelegate* render_widget_delegate, 89 RenderWidgetHostDelegate* render_widget_delegate,
131 RenderFrameHostManager::Delegate* manager_delegate) 90 RenderFrameHostManager::Delegate* manager_delegate)
132 : render_frame_delegate_(render_frame_delegate), 91 : render_frame_delegate_(render_frame_delegate),
133 render_view_delegate_(render_view_delegate), 92 render_view_delegate_(render_view_delegate),
134 render_widget_delegate_(render_widget_delegate), 93 render_widget_delegate_(render_widget_delegate),
135 manager_delegate_(manager_delegate), 94 manager_delegate_(manager_delegate),
136 root_(new FrameTreeNode(this, 95 root_(new FrameTreeNode(this,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 } 157 }
199 158
200 FrameTree::NodeRange FrameTree::SubtreeNodes(FrameTreeNode* subtree_root) { 159 FrameTree::NodeRange FrameTree::SubtreeNodes(FrameTreeNode* subtree_root) {
201 return NodeRange(subtree_root, nullptr); 160 return NodeRange(subtree_root, nullptr);
202 } 161 }
203 162
204 FrameTree::NodeRange FrameTree::NodesExcept(FrameTreeNode* node_to_skip) { 163 FrameTree::NodeRange FrameTree::NodesExcept(FrameTreeNode* node_to_skip) {
205 return NodeRange(root_, node_to_skip); 164 return NodeRange(root_, node_to_skip);
206 } 165 }
207 166
208 FrameTree::ConstNodeRange FrameTree::ConstNodes() const {
209 return ConstNodeRange(root_);
210 }
211
212 bool FrameTree::AddFrame( 167 bool FrameTree::AddFrame(
213 FrameTreeNode* parent, 168 FrameTreeNode* parent,
214 int process_id, 169 int process_id,
215 int new_routing_id, 170 int new_routing_id,
216 blink::WebTreeScopeType scope, 171 blink::WebTreeScopeType scope,
217 const std::string& frame_name, 172 const std::string& frame_name,
218 const std::string& frame_unique_name, 173 const std::string& frame_unique_name,
219 blink::WebSandboxFlags sandbox_flags, 174 blink::WebSandboxFlags sandbox_flags,
220 const blink::WebFrameOwnerProperties& frame_owner_properties) { 175 const blink::WebFrameOwnerProperties& frame_owner_properties) {
221 CHECK_NE(new_routing_id, MSG_ROUTING_NONE); 176 CHECK_NE(new_routing_id, MSG_ROUTING_NONE);
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
471 root_->navigator()->GetDelegate()->DidChangeLoadProgress(); 426 root_->navigator()->GetDelegate()->DidChangeLoadProgress();
472 } 427 }
473 428
474 void FrameTree::ResetLoadProgress() { 429 void FrameTree::ResetLoadProgress() {
475 for (FrameTreeNode* node : Nodes()) 430 for (FrameTreeNode* node : Nodes())
476 node->reset_loading_progress(); 431 node->reset_loading_progress();
477 load_progress_ = 0.0; 432 load_progress_ = 0.0;
478 } 433 }
479 434
480 bool FrameTree::IsLoading() const { 435 bool FrameTree::IsLoading() const {
481 for (const FrameTreeNode* node : ConstNodes()) { 436 for (const FrameTreeNode* node : const_cast<FrameTree*>(this)->Nodes()) {
482 if (node->IsLoading()) 437 if (node->IsLoading())
483 return true; 438 return true;
484 } 439 }
485 return false; 440 return false;
486 } 441 }
487 442
488 void FrameTree::ReplicatePageFocus(bool is_focused) { 443 void FrameTree::ReplicatePageFocus(bool is_focused) {
489 std::set<SiteInstance*> frame_tree_site_instances = 444 std::set<SiteInstance*> frame_tree_site_instances =
490 CollectSiteInstances(this); 445 CollectSiteInstances(this);
491 446
(...skipping 12 matching lines...) Expand all
504 // This is only used to set page-level focus in cross-process subframes, and 459 // This is only used to set page-level focus in cross-process subframes, and
505 // requests to set focus in main frame's SiteInstance are ignored. 460 // requests to set focus in main frame's SiteInstance are ignored.
506 if (instance != root_manager->current_frame_host()->GetSiteInstance()) { 461 if (instance != root_manager->current_frame_host()->GetSiteInstance()) {
507 RenderFrameProxyHost* proxy = 462 RenderFrameProxyHost* proxy =
508 root_manager->GetRenderFrameProxyHost(instance); 463 root_manager->GetRenderFrameProxyHost(instance);
509 proxy->Send(new InputMsg_SetFocus(proxy->GetRoutingID(), is_focused)); 464 proxy->Send(new InputMsg_SetFocus(proxy->GetRoutingID(), is_focused));
510 } 465 }
511 } 466 }
512 467
513 } // namespace content 468 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/frame_host/frame_tree.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698