Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1801843002: Revert of Use the crrev recipe module to fetch commit hashes. (Closed)

Created:
4 years, 9 months ago by qyearsley
Modified:
4 years, 9 months ago
Reviewers:
RobertoCN, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, prasadv
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Use the crrev recipe module to fetch commit hashes. (patchset #2 id:20001 of https://codereview.chromium.org/1773933002/ ) Reason for revert: Causing failures e.g.: https://build.chromium.org/p/tryserver.chromium.perf/builders/android_fyi_perf_bisect/builds/196 Original issue's description: > Use the crrev recipe module to fetch commit hashes. > > BUG=585563 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299254 TBR=prasadv@chromium.org,robertocn@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=585563 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299274

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+578 lines, -790 lines) Patch
M scripts/slave/recipe_modules/auto_bisect/__init__.py View 1 chunk +6 lines, -7 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/bisector.py View 1 chunk +1 line, -7 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.py View 1 chunk +5 lines, -6 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/android_bisector.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/basic_bisect_script.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_build_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/failed_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/mac_bisector.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/missing_metric_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/reversed_basic.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_bisector.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisect.py View 1 chunk +4 lines, -6 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/basic_return_code_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_bad_revision_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisect.expected/broken_good_revision_test.json View 1 chunk +30 lines, -40 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.py View 1 chunk +2 lines, -4 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/aborted_non_telemetry_test.json View 1 chunk +22 lines, -32 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/basic_test.json View 1 chunk +22 lines, -32 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/deps_culprit_test.json View 1 chunk +22 lines, -32 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_direction_test.json View 1 chunk +22 lines, -32 lines 0 comments Download
M scripts/slave/recipes/bisect_test/example_bisect_results.expected/failed_test.json View 1 chunk +22 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
qyearsley
Created Revert of Use the crrev recipe module to fetch commit hashes.
4 years, 9 months ago (2016-03-14 17:30:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801843002/1
4 years, 9 months ago (2016-03-14 17:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801843002/1
4 years, 9 months ago (2016-03-14 17:31:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=299274
4 years, 9 months ago (2016-03-14 17:34:55 UTC) #5
qyearsley
4 years, 8 months ago (2016-03-29 16:35:11 UTC) #6
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1836243002/ by qyearsley@chromium.org.

The reason for reverting is: Relanding because the fix to crrev
(https://codereview.chromium.org/1796993002/) has now landed..

Powered by Google App Engine
This is Rietveld 408576698