scripts/slave/recipes/bisect.py - Issue 1801843002: Revert of Use the crrev recipe module to fetch commit hashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/bisect.py

Issue 1801843002: Revert of Use the crrev recipe module to fetch commit hashes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/auto_bisect/example.expected/windows_x64_bisector.json ('k') | scripts/slave/recipes/bisect.expected/basic.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/bisect.py

diff --git a/scripts/slave/recipes/bisect.py b/scripts/slave/recipes/bisect.py

index d11729ec2cec6f25ad97ebe44169d9e60fbaa9fd..17e0611425510849effda3ec97802fe57d265871 100644

--- a/scripts/slave/recipes/bisect.py

+++ b/scripts/slave/recipes/bisect.py

@@ -258,17 +258,15 @@

def _get_step_data_for_revision(api, revision_data, skip_results=False):

"""Generator that produces step patches for fake results."""

- commit_pos_number = revision_data['commit_pos']

+ commit_pos = revision_data['commit_pos']

commit_hash = revision_data['hash']

test_results = revision_data['test_results']

if 'refrange' in revision_data:

parent_step = 'Resolving reference range.'

- commit_pos = 'refs/heads/master@{#%s}' % commit_pos_number

- step_name = parent_step + 'crrev get commit hash for ' + commit_pos

- yield api.step_data(

- step_name,

- stdout=api.json.output({'git_sha': commit_hash}))

+ step_name = parent_step + 'resolving commit_pos ' + commit_pos

+ yield api.step_data(step_name, stdout=api.raw_io.output('hash:' +

+ commit_hash))

if not skip_results:

step_name = ('Waiting for chromium@%s.gsutil '